Bug 1987806

Summary: [External] External Cluster resources are not updated even after updating the JSON input secret
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: arun kumar mohan <amohan>
Component: ocs-operatorAssignee: arun kumar mohan <amohan>
Status: CLOSED ERRATA QA Contact: shylesh <shmohan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.8CC: ebenahar, jrivera, madam, muagarwa, ocs-bugs, odf-bz-bot, sagrawal, sostapov
Target Milestone: ---   
Target Release: ODF 4.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-12-13 17:44:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description arun kumar mohan 2021-07-29 16:25:35 UTC 
Description of problem (please be detailed as possible and provide log
snippests):
External Cluster is created through JSON input provided in the form of `rook-ceph-external-cluster-details` secret. OCS Operator reads this secret and creates needed resources like Secrets, StorageClasses, ConfigMaps and External CephCluster-CR.

These resources are expected to be updated when the JSON input secret is modified. While debugging BZ:#https://bugzilla.redhat.com/show_bug.cgi?id=1984735, we noticed that except for 'StorageClass' resources, none of the other resources are updated.

Version of all relevant components (if applicable):
OCS 4.8.x (any version)

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
No

Is there any workaround available to the best of your knowledge?
Manually updating each resource, which is tedious and error-prone. No will be short answer.

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
yes

Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:
Not a regression

Steps to Reproduce:
1. Create an external cluster through the JSON input secret
2. Make sure the external cluster is connected successfully
3. Change the JSON input by editing the `rook-ceph-external-cluster-details` secret.

Actual results:
We can see that external cluster reconciles but none of the resources are updated (other than StorageClass resources)

Expected results:
All the external cluster resources updated with the modified input values.


Additional info:
Comment 2 arun kumar mohan 2021-07-30 05:39:44 UTC 
A partial fix, for this BZ, to update the monitoring endpoints, is already up, PR: https://github.com/openshift/ocs-operator/pull/1285
Rest is handled in this PR: https://github.com/openshift/ocs-operator/pull/1286
Comment 11 arun kumar mohan 2021-12-07 13:29:52 UTC 
Configmaps
-----------
rook-ceph-mon-endpoints

Secrets
--------
rook-ceph-mon
rook-ceph-operator-creds
rook-csi-rbd-node
[optional]
rook-ceph-dashboard-link
rook-csi-rbd-provisioner
rook-csi-cephfs-provisioner
rook-csi-cephfs-node
rgw-admin-ops-user
ceph-rgw-tls-cert

StorageClass
-------------
ceph-rbd
[optional]
cephfs
ceph-rgw

Endpoints of CephCluster CR should be updated properly according to the JSON input.
Comment 15 errata-xmlrpc 2021-12-13 17:44:55 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenShift Data Foundation 4.9.0 enhancement, security, and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:5086