Bug 1987850

Summary: php-pear-Text-Diff: FTBFS in Fedora rawhide/f35
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: php-pear-Text-DiffAssignee: Xavier Bachelot <xavier>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 35CC: xavier
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-09 21:08:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1927309, 1992484    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2021-07-29 16:32:14 UTC
php-pear-Text-Diff failed to build from source in Fedora rawhide/f35

https://koji.fedoraproject.org/koji/taskinfo?taskID=72457005


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Please fix php-pear-Text-Diff at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
php-pear-Text-Diff will be orphaned. Before branching of Fedora 36,
php-pear-Text-Diff will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2021-07-29 16:32:18 UTC
Created attachment 1808428 [details]
build.log

Comment 2 Fedora Release Engineering 2021-07-29 16:32:21 UTC
Created attachment 1808429 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2021-07-29 16:32:23 UTC
Created attachment 1808430 [details]
state.log

Comment 4 Fedora Release Engineering 2021-08-01 04:32:34 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-09-23).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 5 Ben Cotton 2021-08-10 13:26:55 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 6 Fedora Release Engineering 2021-08-22 04:26:07 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-09-23).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 7 Xavier Bachelot 2021-09-09 15:23:51 UTC
Fatal error: Uncaught Error: Call to undefined function each() in /builddir/build/BUILDROOT/php-pear-Text-Diff-1.2.2-11.fc36.x86_64/usr/share/pear/Text/Diff/Engine/native.php:195
Stack trace:
#0 /builddir/build/BUILDROOT/php-pear-Text-Diff-1.2.2-11.fc36.x86_64/usr/share/pear/Text/Diff/Engine/native.php(295): Text_Diff_Engine_native->_diag()
#1 /builddir/build/BUILDROOT/php-pear-Text-Diff-1.2.2-11.fc36.x86_64/usr/share/pear/Text/Diff/Engine/native.php(88): Text_Diff_Engine_native->_compareseq()
#2 /builddir/build/BUILD/php-pear-Text-Diff-1.2.2/Text_Diff-1.2.2/Text/Diff.php(59): Text_Diff_Engine_native->diff()
#3 /builddir/build/BUILD/php-pear-Text-Diff-1.2.2/Text_Diff-1.2.2/Text/Diff/Renderer/inline.php(138): Text_Diff->__construct()
#4 /builddir/build/BUILDROOT/php-pear-Text-Diff-1.2.2-11.fc36.x86_64/usr/share/pear/Text/Diff/Renderer.php(165): Text_Diff_Renderer_inline->_changed()
#5 /builddir/build/BUILDROOT/php-pear-Text-Diff-1.2.2-11.fc36.x86_64/usr/share/pear/Text/Diff/Renderer.php(138): Text_Diff_Renderer->_block()
#6 /builddir/build/BUILD/php-pear-Text-Diff-1.2.2/Text_Diff-1.2.2/tests/pear_bug12740.php(24): Text_Diff_Renderer->render()
#7 {main}
  thrown in /builddir/build/BUILDROOT/php-pear-Text-Diff-1.2.2-11.fc36.x86_64/usr/share/pear/Text/Diff/Engine/native.php on line 195



each() was removed from php 8 (https://www.php.net/manual/en/function.each.php)/
Anyway https://pear.php.net/package/Text_Diff is not maintained anymore and has been moved to http://pear.horde.org/ as Horde_Text_Diff.
However php-horde-Horde-Text-Diff is also broken with php 8 and has been removed from Fedora (https://src.fedoraproject.org/rpms/php-horde-Horde-Text-Diff/blob/rawhide/f/dead.package)
php-pear-Text-Diff is used by websvn (https://src.fedoraproject.org/rpms/websvn/blob/rawhide/f/websvn.spec#_24), which is likely why I packaged it in the first place.
I'll file a bug with websvn upstream about PHP 8 support.

Comment 8 Xavier Bachelot 2021-09-09 15:26:42 UTC
https://github.com/websvnphp/websvn/issues/153

Comment 9 Xavier Bachelot 2021-09-09 21:08:36 UTC
php-pear-Text-Diff has been retired in F35 and Rawhide and websvn has been rebuilt with this dependency removed for the same branches.
See https://src.fedoraproject.org/rpms/websvn/c/afa8836c5f2a464b2aa9a17c7dd6d40a082bf639?branch=rawhide