Bug 1988382
| Summary: | annocheck reports pie/pic test failures on non-x86_64 architectures | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Jan Pazdziora <jpazdziora> |
| Component: | glibc | Assignee: | Siddhesh Poyarekar <sipoyare> |
| Status: | CLOSED ERRATA | QA Contact: | Sergey Kolosov <skolosov> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 9.0 | CC: | ashankar, codonell, dj, fweimer, jjaburek, jpazdziora, mnewsome, nickc, pfrankli, rlemosor, sipoyare |
| Target Milestone: | beta | Keywords: | FutureFeature, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glibc-2.34-16.el9 | Doc Type: | No Doc Update |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-17 15:48:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2044387 | ||
|
Description
Jan Pazdziora
2021-07-30 12:39:42 UTC
Actually, the problem is present on ppc64le and aarch64 as well, besides s390x. Executables are not built with -pie on s390x and ppc64le because they do not yet support static-pie. It may be worthwhile to add aarch64 to %pie_arches since it is supposed to be functional. That said though, maybe we need to give a thought to enabling PIE on non-static binaries since with the exception of ldconfig, all of them are dynamic executables. It will need some upstream work though. Siddhesh, I believe that we could fix every executable here except ldconfig. We need to fix up the flag inheritance in the glibc build to achieve this, so there might be some build file changes. However, for ldconfig we will need to work with IBM to enable static PIE for ppc64le and s390x. I will raise this with the IBM teams. (In reply to Siddhesh Poyarekar from comment #4) > That said though, maybe we need to give a thought to enabling PIE on > non-static binaries since with the exception of ldconfig, all of them are > dynamic executables. It will need some upstream work though. Agreed, we should do this upstream. I'll try to do this upstream before 2.35 freezes. With glibc-2.34-8.el9 and annobin-annocheck-10.29-1.el9, we no longer see the pie failure on /usr/sbin/ldconfig /usr/sbin/iconvconfig /usr/libexec/getconf/XBS5_LP64_OFF64 /usr/libexec/getconf/POSIX_V7_LP64_OFF64 /usr/libexec/getconf/POSIX_V6_LP64_OFF64 on s390x and ppc64le (did not test aarch64). Is that expected? The older compose where we still saw annocheck failing had the same glibc-2.34-8.el9 but older annobin-annocheck-10.23-1.el9, so I guess Nick might have insight into what has changed (or shouldn't have changed) in annocheck. (In reply to Jan Pazdziora from comment #8) > Is that expected? Yes - I have added some explicit exceptions for glibc binaries to annocheck's heuristics. So now, glibc rpms should pass annocheck cleanly... This change only went in recently (10.24), so that would explain why older versions of annocheck still complain. Should be fixed by the rebuild. (In reply to Florian Weimer from comment #11) > Should be fixed by the rebuild. This was not correct. The PIE fixes are not yet in. This is now pushed to upstream master. The backport to F35 now shows only one failure on s390x: # rpm -qal 'glibc*' | while read f ; do if test -f "$f" -a ! -L "$f" ; then echo $f ; fi ; done | xargs -L 200 annocheck --verbose --verbose --ignore-gaps --skip-all --test-pic --test-pie 2> /dev/null | grep FAIL: Hardened: /sbin/ldconfig: FAIL: pie test because not built with '-Wl,-pie' (gcc/clang) or '-buildmode pie' (go) (source: ELF header) which is expected since s390x does not support static-pie yet. Rest of the binaries are now built as PIE. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (new packages: glibc), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2022:3917 |