Bug 1988738

Summary:	Does not actually ENABLE_DEDUPE during compile for btrfs CoW deduplication
Product:	[Fedora] Fedora	Reporter:	lnx <lovyagin>
Component:	jdupes	Assignee:	David Cantrell <dcantrell>
Status:	CLOSED ERRATA	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	35	CC:	dcantrell, mattdm
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	jdupes-1.20.2-2.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-13 01:05:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description lnx 2021-07-31 16:26:16 UTC

Description of problem:

Despite Fedora's patch for Makefile in srpm adds ENABLE_DEDUPE compile option, jdupes is not actually compiled with DEDUPE (-B option for do a btrfs copy-on-write deduplication) support. 

Version-Release number of selected component (if applicable):

How reproducible:


Steps to Reproduce:
1. Compile from srpm or install rpm
2. run jdupes -h or jdupes with -B option on a test btrfs directory

Actual results:

jdupes -h does not list -B option

jdupes -B does not work, complying that jdupes is built without DEDUPE support.


Expected results:

jdupes -h do list -B option

jdupes -B do work

Additional info:

Comment 1 lnx 2021-07-31 16:26:50 UTC

Possible jdupes Makefile interpretation bug. I've succeed in compiling with DEDUPE support by patching the srpm's spec file

38c38
< %make_build CFLAGS="%{optflags}" PREFIX="%{_prefix}" MAN_BASE_DIR="%{_mandir}"
---
> %make_build CFLAGS="-DENABLE_DEDUPE %{optflags}" PREFIX="%{_prefix}" MAN_BASE_DIR="%{_mandir}" ENABLE_DEDUPE=1

Comment 2 Ben Cotton 2021-08-10 13:33:25 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 3 David Cantrell 2021-08-10 18:15:21 UTC

Thanks, fixed in this build in rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=73638691

Comment 4 Matthew Miller 2021-12-24 17:49:29 UTC

Looks like that koji build failed. I built it locally, though, and it's still:


$ jdupes -B
This program was built without dedupe support


I think this PR should do it: https://src.fedoraproject.org/rpms/jdupes/pull-request/1

Comment 5 Fedora Update System 2022-01-04 19:44:04 UTC

FEDORA-2022-d188fec35d has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d188fec35d

Comment 6 Fedora Update System 2022-01-05 01:15:17 UTC

FEDORA-2022-d188fec35d has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-d188fec35d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d188fec35d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-01-13 01:05:40 UTC

FEDORA-2022-d188fec35d has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.