Bug 198880
Summary: | Review Request: perl-POE-Component-Client-DNS | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-15 19:09:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 198882, 198884 |
Description
Chris Weyl
2006-07-14 11:35:37 UTC
I have to tell you that the "0" release violates the naming guidelines; please make sure to bump this to "1" before you build. I enabled the test suite just to try it, but I don't think it works under mock due to an undefined network configuration. However, five of the tests did run properly. * source files match upstream: 17d8823b50185e4a2536ca8888d45410 POE-Component-Client-DNS-0.99.tar.gz O package meets naming and packaging guidelines (0 release should be 1) * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. O BuildRequires are proper (BR: perl is redundant) O No need to pass any compiler flags. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(POE::Component::Client::DNS) = 0.99 perl-POE-Component-Client-DNS = 0.99-0.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Net::DNS) perl(POE) perl(Socket) perl(constant) perl(strict) perl(vars) * noarch package; no debuginfo. * %check is present but necessarily disabled for mock. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED Given the recent thread on the list, I'll start submitting future packages with an initial release of 1. +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-4, FC-5) +Close bug Thanks for the review! |