Bug 198885

Bits snipped.

Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Client-HTTP.spec
SRPM URL:
http://home.comcast.net/~ckweyl/perl-POE-Component-Client-HTTP-0.76-1.fc5.src.rpm

This failed to build for me, due to errors in the %check section.  I replaced it
with:

pushd t
rm 01* 02* 09* 11* 50* 54*
popd
make test

and everything built fine.

Note that 0.77 is out (actually came out before your submission, I think), and I
can't fetch 0.76 from cpan to compare.  I don't see anything of issue with this
package, but it's probably best if I review the current version.  (Unless you're
staying away from 0.77 for some reason.)

(In reply to comment #2)
> Note that 0.77 is out (actually came out before your submission, I think), and I
> can't fetch 0.76 from cpan to compare.

If you run:
$ spectool --gf perl-POE-Component-Client-HTTP.spec

several times, you should eventually get a redirect to a CPAN mirror that has
it, such as http://cpan.mirror.anlx.net/

Updated to 0.77...  Fixed the issues in %check; now using the same
_with_network_tests scheme as perl-POE-Component-IRC.

Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Client-HTTP.spec
SRPM URL:
http://home.comcast.net/~ckweyl/perl-POE-Component-Client-HTTP-0.77-1.fc5.src.rpm

I did try via spectool to fetch the 0.76 source about ten times but never
succeeded in hitting a mirror that had it.  Now that this package is updated to
0.77 there are no worries.

Anyway, this builds, installs and checks out fine.


* source files match upstream:
   bca2c306d8c63535845b760883a13644  POE-Component-Client-HTTP-0.77.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
 license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is redundant).
* %clean is present.
* package builds in mock (development, x86_64).
* noarch package; no debuginfo.
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Component::Client::HTTP) = 0.77
   perl(POE::Component::Client::HTTP::Request)
   perl(POE::Component::Client::HTTP::RequestFactory) = 0.01
   perl(POE::Filter::HTTPChunk)
   perl(POE::Filter::HTTPHead) = 0.01
   perl(POE::Filter::HTTPHead_Line)
   perl-POE-Component-Client-HTTP = 0.77-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(HTTP::Response)
   perl(HTTP::Status)
   perl(POE)
   perl(POE::Component::Client::HTTP)
   perl(POE::Component::Client::HTTP::Request)
   perl(POE::Component::Client::HTTP::RequestFactory)
   perl(POE::Filter::Line)
   perl(base)
   perl(bytes)
   perl(strict)
   perl(vars)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful.
   Files=12, Tests=76,  5 wallclock secs ( 2.12 cusr +  0.66 csys =  2.78 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-5)
+Close bug

Thanks for the review!