Bug 1988902
| Summary: | Add macros.build-constraints | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | redhat-rpm-config | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 35 | CC: | ajax, ffesti, fweimer, igor.raits, jonathan, j, mhroncok, pmatilai, sanjay.ankur, torsava |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | redhat-rpm-config-183-3.fc34 redhat-rpm-config-176-3.fc33 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-08-30 21:30:36 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1982748 | ||
|
Description
Michel Lind
2021-08-02 04:30:11 UTC
FEDORA-2021-a5cd9680ba has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a5cd9680ba FEDORA-2021-7c42e41506 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7c42e41506 FEDORA-2021-7c42e41506 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-7c42e41506` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7c42e41506 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-a5cd9680ba has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-a5cd9680ba` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a5cd9680ba See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle. Changing version to 35. This is severely broken.
For starters, it breaks debuginfo processing. For a simple reproducer, take "popt" package from dist-git, add "%limit_build" (also reproduced with "%limit_build -m 8192" etc) to top of %build and try to build. It consistently fails with:
> Processing files: popt-debugsource-1.18-6.fc35.x86_64
> error: Empty %files file /builddir/build/BUILD/popt-1.18/debugsourcefiles.list
Similar results with the other package I tested with.
AFAICS it simply breaks all other uses of %_smp_build_ncpus (whether in spec or rpm internally) outside the spec section where it appears:
'%global _smp_build_ncpus "${_cur_max_jobs}"' gets "executed" during *spec parse*, and at that time there's never any _cur_max_jobs environment variable around. That will only be available during the execution of the shell section where the macro was called, ie %build. It will again go defunct when the build moves on the %install and later, which do various amount of parallel processing all hooked on that variable.
This needs to be reverted before it gets shipped anywhere in this condition.
FEDORA-2021-9042da4d79 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9042da4d79 FEDORA-2021-127aaf73b9 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-127aaf73b9 FEDORA-2021-9042da4d79 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-9042da4d79` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9042da4d79 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-127aaf73b9 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-127aaf73b9` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-127aaf73b9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. NAK, this is a bad design, see https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CWQIAKEI6Q7VJJWNGFSRW7ZR47RLFLGY/ Please DO NOT submit updates to stable releases before we've agreed upon an implementation and the dust settles in rawhide. That would be closer to final freeze of F35. FEDORA-2021-9042da4d79 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. And so the bad design that requires adding ugly crap to %make_build went into production :( Uh, I'd given the update negative karma to ensure it wouldn't go stable initially, but I missed the second set of updates. Michel, can you please take a look and make the necessary fixes here? There do still seem to be issues with this implementation? FEDORA-2021-127aaf73b9 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days |