Bug 1988959

Summary: [Cinderlib] - The attached disk isn't attached to the cloned VM from template
Product: [oVirt] ovirt-engine Reporter: sshmulev
Component: BLL.StorageAssignee: shani <sleviim>
Status: CLOSED CURRENTRELEASE QA Contact: Shir Fishbain <sfishbai>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.4.8.2CC: ahadas, bugs
Target Milestone: ovirt-4.5.0Keywords: ZStream
Target Release: 4.5.0Flags: pm-rhel: ovirt-4.5?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-20 06:33:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description sshmulev 2021-08-02 07:42:56 UTC 
Description of problem:
When attaching a disk from MBS domain to a VM and then creating a temaplate from it, the cloned vm from the template has only the OS disk without the disk from the MBS domain.

Version-Release:
vdsm-4.40.80.3-1.el8ev
ovirt-engine-4.4.8.2-0.11.el8ev.noarch

How reproducible:
100%

Steps to Reproduce:
1) Create new MBS domain via rest API
2) Create new disk under the neww MBS domain.
3) Create New vm and attach the disk(virio-scsi,3G,Thin provision) to it.
4) Run the VM
5) power off the VM
6) create template from the VM (Make template button in the UI) when the new vm is selected.
7) Go to templates and select the new template that has been created and press the "New VM" button.

Actual results:
The cloned VM has only the OS disk attached to it. 
The MBS disk that was mentioned in steps 2-3 is not attached to it.

Expected results:
The loned VM should be identical to the one from the template.

Additional info:
Seems like a new issue since it didn't work in 4.3 and also in 4.4.7
Comment 2 Arik 2022-02-23 13:20:38 UTC 
This bz is about clone vm *from template* (not clone vm) so dropping unrelated patches
Comment 4 shani 2022-02-24 14:34:14 UTC 
The fix made in https://github.com/oVirt/ovirt-engine/pull/56 is valid and seems to solve the issue (attached screen record)
Comment 6 Shir Fishbain 2022-04-07 11:28:54 UTC 
Verified 
The new VM was created from a template with both disks:  iscsi disk (Bootable) and MBS disk

ovirt-engine-4.5.0-0.237.el8ev.noarch
vdsm-4.50.0.10-1.el8ev.x86_64
Comment 7 Sandro Bonazzola 2022-04-20 06:33:59 UTC 
This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.