Bug 1989269

Summary:	Online VM Snapshot storing incorrect VM spec
Product:	Container Native Virtualization (CNV)	Reporter:	Michael Henriksen <mhenriks>
Component:	Storage	Assignee:	skagan
Status:	CLOSED ERRATA	QA Contact:	dalia <dafrank>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.9.0	CC:	alitke, cnv-qe-bugs, mrashish, rsdeor, skagan, yadu, ycui
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	CNV v4.9.0-191, virt-controller v4.9.0-43	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-02 15:59:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Henriksen 2021-08-02 19:12:44 UTC

Description of problem:

Currently, when snapshotting a running VM, the current VM spec at the time of the snapshot is stored.  This is wrong.  What should be stored is the VM spec at the time the VM started.

To understand why the current behavior is problematic, consider that the VM spec may be edited while the VM is running.  But those changes will not take effect until the VM is restarted.

Version-Release number of selected component (if applicable):


How reproducible:  100%


Steps to Reproduce:
1.  Create running VM
2.  Add DataVolumeTemplate to VM
3.  Snapshot VM

Actual results:

The new volume is included in the snapshot.


Expected results:

The new volume should not be snapshotted.


Additional info:

Comment 1 Maya Rashish 2021-08-16 16:20:31 UTC

Can you mention which upstream commit fixes this? thanks!

Comment 2 skagan 2021-08-17 12:46:09 UTC

@mrashish this is currently in a pr, was not merged nor backported yet (pr : https://github.com/kubevirt/kubevirt/pull/6241)

Comment 3 dalia 2021-10-04 11:31:00 UTC

verified on CNV 4.9.0

Comment 6 errata-xmlrpc 2021-11-02 15:59:51 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.9.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4104

Comment 7 errata-xmlrpc 2021-11-02 16:02:14 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.9.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4104