Bug 1989379

Summary:	GPSD time will jump back 1024 weeks at after week=2180 (23-October-2021)
Product:	[Fedora] Fedora	Reporter:	Chris Murphy <bugzilla>
Component:	gpsd	Assignee:	Miroslav Lichvar <mlichvar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	35	CC:	mail, mlichvar, TicoTimo
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	gpsd-3.20-3.fc33 gpsd-3.22-5.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-20 01:09:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Murphy 2021-08-03 05:46:45 UTC

Ran into this upstream bug report, and figure we need our own bug to track it. Rawhide can get 3.23 which will fix it; and backport will be needed for 34 and maybe also 33.


Problem:

"This code is going to trigger a 1024 week backward time jump from Saturday October 16, 2021 to Sunday March 3, 2002."

Fix:

"Yes, it will be ugly, when I decide on the fix, I'll alert maintainners so they can backport.  OTOH, that will quickly flush out a lot of outdated gpsd installs."

Comment 1 Miroslav Lichvar 2021-08-03 06:52:20 UTC

The fix seems to be this commit:
https://gitlab.com/gpsd/gpsd/-/commit/7f30d88d04dc62b8bd6265ad1d09d72d220f97f6.patch

It has many conflicts when applied to 3.22.

3.23 breaks the API/ABI again, so we will need to rebuild the client packages. The attitude field was moved, some be patching may needed.

Comment 2 Miroslav Lichvar 2021-08-10 14:16:48 UTC

Debian has a backported fix here:
https://salsa.debian.org/debian-gps-team/pkg-gpsd/-/blob/master/debian/patches/7f30d88d0_gpsd-timebase.c-Don-t-compute-wrong-GPS-rollover-after-2020-10-23

Comment 3 Miroslav Lichvar 2021-08-11 10:31:06 UTC

It seems there is one hunk in the upstream commit that fix the issue and everything else is related to fixing the tests as a result of that change. To keep it simple, I'm cherry-picking that commit and leaving the tests broken.

I'll submit updates for F33 and F34 shortly.

Comment 4 Fedora Update System 2021-08-11 10:57:11 UTC

FEDORA-2021-2213876e75 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2213876e75

Comment 5 Fedora Update System 2021-08-11 10:57:11 UTC

FEDORA-2021-a7144383e1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a7144383e1

Comment 6 Fedora Update System 2021-08-12 01:20:08 UTC

FEDORA-2021-2213876e75 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-2213876e75`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2213876e75

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-08-12 01:47:29 UTC

FEDORA-2021-a7144383e1 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-a7144383e1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a7144383e1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-08-20 01:09:52 UTC

FEDORA-2021-a7144383e1 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2021-08-20 01:19:49 UTC

FEDORA-2021-2213876e75 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.