Bug 1989615

Summary:	HBO: Every node update triggers "lsp-add" for HBO ports unnecessarily
Product:	OpenShift Container Platform	Reporter:	Surya Seetharaman <surya>
Component:	Networking	Assignee:	Surya Seetharaman <surya>
Networking sub component:	ovn-kubernetes	QA Contact:	Anurag saxena <anusaxen>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	anusaxen
Version:	4.7
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-18 17:44:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2000214

Description Surya Seetharaman 2021-08-03 14:50:50 UTC

Description of problem:

In OpenShift, kubevirt edits a heartbeat timestamp annotation on the node periodically. This causes the node watcher's add function in OVN-K to trigger a node update. Even if the port's MAC is already set, we keep re-processing the MAC annotation for each node which causes a bunch of:

/usr/bin/ovn-nbctl --timeout=15 -- --may-exist lsp-add ovn-worker2 int-ovn-worker2 -- lsp-set-addresses int-ovn-worker2 0a:58:0a:f4:00:03
I0803 09:39:47.023484      51 ovs.go:207] exec(581): /usr/bin/ovn-nbctl --timeout=15 -- --may-exist lsp-add ovn-worker int-ovn-worker -- lsp-set-addresses int-ovn-worker 0a:58:0a:f4:02:03

to get executed. This is due to a bug in the `GetPortAddresses` function in OVN-K.


Version-Release number of selected component (if applicable):
4.9 and below


How reproducible: Always

Sample logs:

I0803 09:14:40.066693      51 master.go:231] Creating / updating node ovn-worker hybrid overlay port with mac 0a:58:0a:f4:02:03
I0803 09:14:40.068880      51 master.go:231] Creating / updating node ovn-worker2 hybrid overlay port with mac 0a:58:0a:f4:00:03
I0803 09:19:31.382330      51 master.go:231] Creating / updating node ovn-control-plane hybrid overlay port with mac 0a:58:0a:f4:01:03
I0803 09:19:41.438269      51 master.go:231] Creating / updating node ovn-worker hybrid overlay port with mac 0a:58:0a:f4:02:03
I0803 09:19:41.441319      51 master.go:231] Creating / updating node ovn-worker2 hybrid overlay port with mac 0a:58:0a:f4:00:03
I0803 09:24:32.765837      51 master.go:231] Creating / updating node ovn-control-plane hybrid overlay port with mac 0a:58:0a:f4:01:03
I0803 09:24:42.806418      51 master.go:231] Creating / updating node ovn-worker2 hybrid overlay port with mac 0a:58:0a:f4:00:03
I0803 09:24:42.810539      51 master.go:231] Creating / updating node ovn-worker hybrid overlay port with mac 0a:58:0a:f4:02:03
I0803 09:29:34.326222      51 master.go:231] Creating / updating node ovn-control-plane hybrid overlay port with mac 0a:58:0a:f4:01:03
I0803 09:29:44.396047      51 master.go:231] Creating / updating node ovn-worker hybrid overlay port with mac 0a:58:0a:f4:02:03
I0803 09:29:44.397670      51 master.go:231] Creating / updating node ovn-worker2 hybrid overlay port with mac 0a:58:0a:f4:00:03
I0803 09:34:35.842705      51 master.go:231] Creating / updating node ovn-control-plane hybrid overlay port with mac 0a:58:0a:f4:01:03
I0803 09:34:45.878037      51 master.go:231] Creating / updating node ovn-worker2 hybrid overlay port with mac 0a:58:0a:f4:00:03
I0803 09:34:45.881372      51 master.go:231] Creating / updating node ovn-worker hybrid overlay port with mac 0a:58:0a:f4:02:03
I0803 09:39:36.971651      51 master.go:231] Creating / updating node ovn-control-plane hybrid overlay port with mac 0a:58:0a:f4:01:03
I0803 09:39:47.023406      51 master.go:231] Creating / updating node ovn-worker2 hybrid overlay port with mac 0a:58:0a:f4:00:03
I0803 09:39:47.023452      51 master.go:231] Creating / updating node ovn-worker hybrid overlay port with mac 0a:58:0a:f4:02:03



Fix is posted here: https://github.com/ovn-org/ovn-kubernetes/pull/2395

Will port it downstream and backport it.

Comment 1 Surya Seetharaman 2021-08-04 08:18:25 UTC

Upstream commit has merged. https://github.com/ovn-org/ovn-kubernetes/pull/2395

Comment 4 Anurag saxena 2021-08-31 19:30:23 UTC

Sorry..verified wrong bug. Moving back to assigned

Comment 8 errata-xmlrpc 2021-10-18 17:44:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759