Bug 1989794
| Summary: | engine still generates duplicate address for hotplug disks | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Germano Veit Michel <gveitmic> |
| Component: | ovirt-engine | Assignee: | Arik <ahadas> |
| Status: | CLOSED ERRATA | QA Contact: | Evelina Shames <eshames> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.4.5 | CC: | ahadas, eshames, mavital, unixbasis |
| Target Milestone: | ovirt-4.4.8 | Keywords: | Reopened |
| Target Release: | --- | Flags: | eshames:
testing_plan_complete-
|
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-engine-4.4.8.4 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-09-08 14:12:12 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Germano Veit Michel
2021-08-04 02:42:57 UTC
(In reply to Germano Veit Michel from comment #0) > How reproducible: > 0% on 4.4.7, tried 2 ways: > - In admin portal, select multiple disks and activate/deactivate > simultaneously > - python sdk doing 20 hotplugs in a loop. Just tried with connections=20, pipeline=20, wait=False to increase paralellism with async, still doesnt reproduce. Yeah, it should no longer happen since 4.4.6 that includes the fix for bz 1927243 Now there is no parallel assignment of addresses and the devices monitoring should not interfere with those assignments so I hope it fixes this issue once and for all (In reply to Germano Veit Michel from comment #0) > How reproducible: > 0% on 4.4.7, tried 2 ways: > - In admin portal, select multiple disks and activate/deactivate > simultaneously > - python sdk doing 20 hotplugs in a loop. In light of the above and considering that the fix for bz 1927243 is likely to solve it, I'm closing it as CURRENTRELEASE on 4.4.7 (In reply to Arik from comment #4) > (In reply to Germano Veit Michel from comment #0) > > How reproducible: > > 0% on 4.4.7, tried 2 ways: > > - In admin portal, select multiple disks and activate/deactivate > > simultaneously > > - python sdk doing 20 hotplugs in a loop. > > In light of the above and considering that the fix for bz 1927243 is likely > to solve it, I'm closing it as CURRENTRELEASE on 4.4.7 Thanks, doing a KCS to put all the fixes together so we don't raise this bug again :) Arik, I'm going to re-open this. Customer upgraded to 4.4.7 and it still happens for them, and I still can't reproduce.
So I assume the bug is somehow still there and there, maybe just harder to hit. See:
2021-08-04 19:07:53,870+02 INFO [org.ovirt.engine.core.bll.Backend] (ServerService Thread Pool -- 40) [] Running ovirt-engine 4.4.7.7-0.1.el8ev
2021-08-06 06:45:42,883+02 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.HotPlugDiskVDSCommand] (default task-929) [146bf104-e8bb-4b21-8aa0-80958e77d9cb] Disk hot-plug: <?xml version="1.0" encoding="UTF-8"?><hotplug>
...
<address bus="0" controller="0" unit="1" type="drive" target="0"/>
<serial>34f1d6e1-e9c0-493c-9009-340764473212</serial>
...
2021-08-06 06:45:43,568+02 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.HotPlugDiskVDSCommand] (default task-932) [f758b383-6534-45f1-9bba-d282d4576472] Disk hot-plug: <?xml version="1.0" encoding="UTF-8"?><hotplug>
...
<address bus="0" controller="0" unit="1" type="drive" target="0"/>
<serial>1b43b270-1c5d-432e-80a1-c1ca07e3522b</serial>
...
As above, the addresses are duplicate, the first succeeded but the second, with correlation f758b383-6534-45f1-9bba-d282d4576472, failed as expected:
2021-08-06 06:45:44,402+02 ERROR [org.ovirt.engine.core.bll.storage.disk.AttachDiskToVmCommand] (default task-932) [f758b383-6534-45f1-9bba-d282d4576472] Command 'org.ovirt.engine.core.bll.storage.disk.AttachDiskToVmCommand' failed: EngineException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSErrorException: VDSGenericException: VDSErrorException: Failed to HotPlugDiskVDS, error = Requested operation is not valid: Domain already contains a disk with that address, code = 45 (Failed with error FailedToPlugDisk and code 45)
Since this issue is really hard to reproduce, we decided to verify it by running our hotplug regression tests: All tests passed. Verified on ovirt-engine-4.4.8.4-0.7.el8ev. Moving to 'VERIFIED'. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (RHV Manager (ovirt-engine) [ovirt-4.4.8]), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2021:3460 |