Bug 1990149
| Summary: | Review Request: rust-clap-verbosity-flag - Easily add a `--verbose` flag to CLIs using Structopt | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rust-clap-verbosity-flag-0.3.2-1.fc36 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-09-03 14:59:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1990648 | ||
|
Description
Davide Cavalca
2021-08-04 21:13:18 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73293004 Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- (almost) latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines
Three minor issues:
1) Version 0.3.2 was released since you filed the review request.
Update from 0.3.1 to 0.3.2 before or after importing, if possible.
2) Maybe drop the Markdown markup from Summary (the backticks around `--verbose`), or replace them with normal quotation marks (")?
I know of no place in the ecosystem that renders Summary or %description text as markdown, so they are only weird for no benefit.
3) Drop "examples" from "%doc".
As mentioned in the other reviews, this is superfluous since the "examples" directory is already included in the -devel package anyway.
Please take these into account when importing / building the package.
Other than that, Package APPROVED.
Thanks! Will get this updated and fixed. $ fedpkg request-repo rust-clap-verbosity-flag 1990149 https://pagure.io/releng/fedora-scm-requests/issue/36558 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clap-verbosity-flag |