Bug 199016
| Summary: | Review Request: mxml - Miniature XML development library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Anthony Green <green> | ||||
| Component: | Package Review | Assignee: | Michael J Knox <michael> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-07-19 16:30:53 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779, 199021 | ||||||
| Attachments: |
|
||||||
|
Description
Anthony Green
2006-07-15 17:42:49 UTC
Created attachment 132521 [details]
Updated mxml spec file
This updated spec file replaces a /usr/lib reference with %{_libdir} for
x86-64.
Hi. I will do the review for this.
Review for release 3:
* RPM name is OK
* Source mxml-2.2.2.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of mxml-devel looks OK
* rpmlint of mxml looks OK
* File list of mxml-devel looks OK
* File list of mxml looks OK
* INSERT RESULT OF RUN TEST
Needs work:
* Spec file: some paths are not replaced with RPM macros
(wiki: QAChecklist item 7)
Notes:
You need to use %{_datadir} not /usr/share
Fix this up and I can approve this package.
(In reply to comment #2) > Hi. I will do the review for this. Thanks. > * INSERT RESULT OF RUN TEST Testing library... ./testmxml test.xml >temp1.xml 2>temp1s.xml ./testmxml temp1.xml >temp2.xml 2>temp2s.xml Stdio file test passed! String test passed! File descriptor test passed! > Needs work: > * Spec file: some paths are not replaced with RPM macros > (wiki: QAChecklist item 7) Fixed. New bits here: Spec URL: http://people.redhat.com/~green/FE/FC5/mxml.spec SRPM URL: http://people.redhat.com/~green/FE/FC5/mxml-2.2.2-4.src.rpm Cool, looks great. APPROVED. Please be sure to close this bug report once inmported into CVS. Thanks. |