Bug 1990373

Summary: python-argh fails to build with Python 3.10: AssertionError
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: python-arghAssignee: Charalampos Stratakis <cstratak>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 35CC: besser82, cstratak, mhroncok, python-sig, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-12-02 21:28:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1890881, 1927309, 1992484    

Description Tomáš Hrnčiar 2021-08-05 09:42:22 UTC
python-argh fails to build with Python 3.10.0rc1.

=================================== FAILURES ===================================
_____________________________ test_invalid_choice ______________________________
    def test_invalid_choice():
        def cmd(args):
            return 1
    
        # root level command
    
        p = DebugArghParser()
        p.add_commands([cmd])
    
>       assert run(p, 'bar', exit=True).startswith('invalid choice')
E       assert False
E        +  where False = <built-in method startswith of str object at 0x7fffb9a853e0>('invalid choice')
E        +    where <built-in method startswith of str object at 0x7fffb9a853e0> = "argument {cmd}: invalid choice: 'bar' (choose from 'cmd')".startswith
E        +      where "argument {cmd}: invalid choice: 'bar' (choose from 'cmd')" = run(DebugArghParser(prog='setup.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True), 'bar', exit=True)
test/test_integration.py:379: AssertionError
____________________________ test_explicit_cmd_name ____________________________
    def test_explicit_cmd_name():
    
        @argh.named('new-name')
        def orig_name():
            return 'ok'
    
        p = DebugArghParser()
        p.add_commands([orig_name])
>       assert run(p, 'orig-name', exit=True).startswith('invalid choice')
E       assert False
E        +  where False = <built-in method startswith of str object at 0x7fffb9ab7bb0>('invalid choice')
E        +    where <built-in method startswith of str object at 0x7fffb9ab7bb0> = "argument {new-name}: invalid choice: 'orig-name' (choose from 'new-name')".startswith
E        +      where "argument {new-name}: invalid choice: 'orig-name' (choose from 'new-name')" = run(DebugArghParser(prog='setup.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True), 'orig-name', exit=True)
test/test_integration.py:513: AssertionError
=========================== short test summary info ============================
FAILED test/test_integration.py::test_invalid_choice - assert False
FAILED test/test_integration.py::test_explicit_cmd_name - assert False
============== 2 failed, 72 passed, 2 skipped, 4 xfailed in 0.57s ==============

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/02359235-python-argh/

For all our attempts to build python-argh with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-argh/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 is already included in Fedora 35. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2021-08-10 13:35:27 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 2 Fedora Release Engineering 2021-08-22 04:27:55 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-09-30).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 3 Fedora Release Engineering 2021-09-12 04:26:40 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-09-30).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 4 Charalampos Stratakis 2021-09-16 17:55:07 UTC
Currently two packages require argh.

python-watchdog for which a PR is being prepared upstream to remove the dependency: https://github.com/gorakhargosh/watchdog/pull/836/files

And barman for which I've created an issue: https://github.com/EnterpriseDB/barman/issues/398

Ideally the dependency can be dropped from those packages and I'll retire the package, but meanwhile I would prefer to just disable the tests. What do you think?

Comment 5 Tomáš Hrnčiar 2021-09-17 05:51:42 UTC
(In reply to Charalampos Stratakis from comment #4)
> Ideally the dependency can be dropped from those packages and I'll retire
> the package, but meanwhile I would prefer to just disable the tests. What do
> you think?

I agree with this approach. Thank you for taking care of this.

Comment 6 Miro Hrončok 2021-09-17 08:43:38 UTC
Instead of coordinated retirement, may I suggest you orphan the package immediately and let the watchdog and barman maintainers decide whether they want to take it or drop the dependency?

Comment 7 Charalampos Stratakis 2021-10-04 16:43:09 UTC
I've disabled the tests to make the package build for now on rawhide and F35.

python-watchdog has released a new version without argh. PR's for rawhide and F35:
https://src.fedoraproject.org/rpms/python-watchdog/pull-request/5
https://src.fedoraproject.org/rpms/python-watchdog/pull-request/6

python-pytest-watch had added the dependency on argh due to missing dependency on watchdog at the time, hence it's redundant now:
https://src.fedoraproject.org/rpms/python-pytest-watch/pull-request/2
https://src.fedoraproject.org/rpms/python-pytest-watch/pull-request/3

And the last dependent is barman for which I have created an issue upstream:
https://github.com/EnterpriseDB/barman/issues/398

I'll work on a patch for it. Then hopefully we can retire argh.

Comment 8 Charalampos Stratakis 2021-12-02 21:28:03 UTC
The package has been retired in rawhide.