Bug 1990790

Summary: [RFE] add possibility to resize bookmarks dropdown menu
Product: Red Hat Satellite Reporter: Stefan Nemeth <snemeth>
Component: SearchAssignee: Maria <magaphon>
Status: CLOSED ERRATA QA Contact: Peter Ondrejka <pondrejk>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.9.0CC: afeferku, apatel, aruzicka, kgaikwad, lvrtelov, magaphon, mhulan, pcreech, pondrejk
Target Milestone: 6.13.0Keywords: EasyFix, FutureFeature, Triaged, UserExperience
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-katello-4.7.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-03 13:20:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Stefan Nemeth 2021-08-06 08:56:27 UTC
Description of problem:

If bookmark has a long name, it is cropped 


Version-Release number of selected component (if applicable):

6.9.4

How reproducible:

100%

Steps to Reproduce:
1. hosts -> all hosts
2. create some search, for example "architecture = x86_64 and activation_key = centos7 and environment = common"
3. dropdown menu -> bookmark the search 
4. assign a long name, for example Centos7_x86_64_common_nosub
5. click on dropdown menu next to search

Actual results:

Bookmark name is cropped

Expected results:

Have possibility to expand drop down menu or expand automatically to match longest bookmark name

Additional info:

Either with the mouse, or in the Satellite settings, or automatically according to the number of bookmarks and their name length.

These the bookmarks dropdown menu are different in All Hosts and Content Hosts.
In All Hosts is 'save new bookmark' in the first place, in Content Hosts it is in the end.

change the search method as All hosts will start searching immediately after selecting a saved bookmark.
In Content hosts, after selecting a bookmark, enter or the search button must be pressed.

Comment 1 Brad Buckingham 2022-09-02 20:25:18 UTC
Upon review of our valid but aging backlog the Satellite Team has concluded that this Bugzilla does not meet the criteria for a resolution in the near term, and are planning to close in a month. This message may be a repeat of a previous update and the bug is again being considered to be closed. If you have any concerns about this, please contact your Red Hat Account team.  Thank you.

Comment 2 Brad Buckingham 2022-09-05 22:55:19 UTC
Upon review of our valid but aging backlog the Satellite Team has concluded that this Bugzilla does not meet the criteria for a resolution in the near term, and are planning to close in a month. This message may be a repeat of a previous update and the bug is again being considered to be closed. If you have any concerns about this, please contact your Red Hat Account team.  Thank you.

Comment 6 Maria 2022-11-10 13:35:51 UTC
This bug is fixed in the foreman and plugins search, but no in the Katello search. So even if Content Hosts page will be removed this bug will still be in different Katello pages like "Products"

Comment 7 Marek Hulan 2022-11-11 11:05:35 UTC
How complicated would it be to reuse Foreman's widget in Katello? And does the number of pages matter or once we fix it e.g. for content views, we can easily reuse on all pages?

Comment 8 Maria 2022-11-11 12:14:04 UTC
I would assume it will be complicated as the issue in Katellos bookmarks is in all Angular pages.
We can add css to Katello if this helps? to wrap and break long bookmarks into several rows.

Comment 9 Marek Hulan 2022-11-15 08:03:44 UTC
Ah, gotcha. I guess we never even tried mixing Angular with React. If the CSS tweaks help I'd consider this BZ resolved. Unless reimplementing Angular pages in react is feasible in a reasonable time.

Comment 10 Maria 2022-11-22 13:50:05 UTC
Connecting redmine issue https://projects.theforeman.org/issues/35771 from this bug

Comment 11 Bryan Kearney 2022-11-23 20:02:30 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/35771 has been resolved.

Comment 14 Peter Ondrejka 2023-01-09 14:21:42 UTC
Checked on Satellite 6.13 snap 5 using bookmarks on the Hosts page. The dropdown now does stretch with long names, but I wonder if we should also break the line once it reaches certain size (as it is in katello-style bookmark dropdowns). Really long names make the dropdown overflow the page (see attached screenshot)

Comment 16 Brad Buckingham 2023-01-19 17:45:45 UTC
Hi Maria,

Is the formatting mentioned in comment 14 something that can be easily addressed?

If not, I'd recommend that issue be tracked separately from this RFE, unless we feel users are likely to have bookmarks that that long.

Thanks!

Comment 17 Maria 2023-01-24 20:01:57 UTC
Hi, this cant be addressed simply, there should be a new rfe for this.

Comment 18 Stefan Nemeth 2023-02-07 10:25:46 UTC
or just set a character limit for length of bookmark?

Comment 19 Adam Ruzicka 2023-02-10 10:32:53 UTC
Filed https://bugzilla.redhat.com/show_bug.cgi?id=2168866 per #16 and #17.

@Peter could we get it in as-is now?

Comment 20 Peter Ondrejka 2023-02-14 16:40:50 UTC
Fair enough, the original request is fulfilled, the bookmarks drop down is resizable. Verified on Sat 6.13 snap 10

Comment 23 errata-xmlrpc 2023-05-03 13:20:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.13 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2097