Bug 1990944
| Summary: | Review Request: rust-cursive-tabs - Tabs for gyscos/cursive views | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rust-cursive-tabs-0.6.0-2.fc36 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-09-03 15:06:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1997731 | ||
|
Description
Davide Cavalca
2021-08-06 16:00:22 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73393456 Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines
Two minor issues:
1) please leave the "# Initial patched metatada" comment in there
Just for consistency with 99.9% of rust-sig packages.
2) "%doc examples README.md CHANGELOG.md assets/README.md"
This will not do what you think. It's a bug in rust2rpm's new %doc and %license detection logic.
"%doc README assets/README.md" will actually copy "README.md" to "%{_docdir}/README.md" and then prompty overwrite it with the second "README.md" from "assets/README.md".
Additionally, the "examples" directory is already included by default in the same package (under /usr/share/cargo/registry/$crate/$version/ with all the other source files), so including this as %doc just makes them duplicate files within the same package for no reason.
So please replace this %doc line with "%doc README.md CHANGELOG.md" before importing.
Other than that, package APPROVED.
Good catch, will fix that, thanks! $ fedpkg request-repo rust-cursive-tabs 1990944 https://pagure.io/releng/fedora-scm-requests/issue/36554 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cursive-tabs |