Bug 1991296

Summary: digikam version request 7.2.0
Product: [Fedora] Fedora EPEL Reporter: Aram Minasyan <aram.minasyan>
Component: digikamAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel8CC: alekcejk, kde-sig, me, rdieter, smparrish, tdawson, than, viktor.vix.jancik
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: digikam-7.3.0-4.el8.next Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-29 01:12:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2007780    
Bug Blocks:    

Description Aram Minasyan 2021-08-08 22:26:55 UTC
**Description of problem:

Please update digikam to version 7.2.0

**Version-Release number of selected component (if applicable):

7.2.0

**How reproducible:

Successful build is possible with opencv-3.4.10
the current version of opencv-3.4.6-6 in el8 causes errors due to cmake not detecting opencv version correctly

--  libopencv found.......................... NO
CMake Error at core/cmake/modules/MacroUtils.cmake:47 (message):
   libopencv is needed. You need to install the libopencv (version >= 3.3.0) development package.
Call Stack (most recent call first):
  core/CMakeLists.txt:544 (PRINT_LIBRARY_STATUS)


Installing opencv-devel-3.4.10-2.el8.x86_64 from build here https://copr.fedorainfracloud.org/coprs/aminasyan/el8-collection/build/2446834/ move the digikam build forward


**Steps to Reproduce:(steps to build)

1. build opencv-3.4.10-2.el8 from here (spec or src.rpm file) https://download.copr.fedorainfracloud.org/results/aminasyan/el8-collection/epel-8-x86_64/02446834-opencv/

2. Install the opencv-devel-3.4.10-2.el8.x86_64 package as required, I have added a BuildRequires: pkgconfig(opencv) >= 3.4.10 to digikam-7.2.0-5.el8

3. Build digikam-7.2.0-5.el8 from here (srpm or spec file)  https://download.copr.fedorainfracloud.org/results/aminasyan/el8-collection/epel-8-x86_64/02449720-digikam/


**Actual results:

digikam-7.2.0-5.el8 is not available in EPEL

**Expected results:

digikam-7.2.0-5.el8 will be available in Fedora EPEL

**Additional info:

SMFL-devel & libdc1394-devel are also required for building opencv-3.4.10-2.el8. If you cannot bypass the requirement then the copr builds are here 
https://copr.fedorainfracloud.org/coprs/aminasyan/el8-collection/build/2446432/
https://copr.fedorainfracloud.org/coprs/aminasyan/el8-collection/build/2446176/

Regards
Aram

Comment 1 Aram Minasyan 2021-08-10 14:40:37 UTC
A koji build of 7.2.0-4.el8 was attempted by @tdawson
looping in to get traction.

Comment 2 Troy Dawson 2021-08-10 16:29:31 UTC
opencv comes from RHEL.  Having an opencv build in copr, or anyplace else doesn't do any good to a final EPEL build.  Though it is handy for testing.
We can always request a bump in version, and it may, or may not happen in RHEL.

Why did you choose opencv-3.4.10 ?
Unless I missed it, I wasn't seeing any particular version jumping out in my build logs.

Comment 3 Aram Minasyan 2021-08-10 21:22:40 UTC
digikam 7.2.0 won't build with opencv-3.4.6, I had to bump the version to 3.4.10.
Like I mentioned above cmake modules/macro doesn't detect opencv-3.4.6, but detects 3.4.10 fine.
Maybe opencv-3.4.10 can be an update from EPEL on top of RHEL provided package.

BTW, I have also successfully built digikam-7.3.0 https://copr.fedorainfracloud.org/coprs/aminasyan/el8-collection/build/2504254/

This was all in a quest to get HEIF/HEIC files & metadata/gps recognized.

Comment 4 Aram Minasyan 2021-08-10 21:28:05 UTC
If you can get cmake to detect opencv-3.4.6 properly, then there is no need to bump the version of opencv.

Comment 5 Troy Dawson 2021-09-24 15:30:21 UTC
I've been working on this today.
The section that is missing from opencv-3.4.6 is dnn support. (Deep Neural Networks).
It looks like digikam is using dnn in it's facesengine.  (Face Recognition)
I'm trying to pull the face recognition out.  I'd rather have an updated digikam without face recognition, than the older digikam (also without face recognition)
Although it does have a ENABLE_FACESENGINE_DNN setting so I can supposedly turn it off, there are several dnn settings and headers hard coded in.

So ... progress.  We'll see how long it takes me.

Comment 6 Troy Dawson 2021-09-24 20:35:39 UTC
Progress, but not necessarily good progress.
facesengine is one of the core digikam libraries.  Although it is possible to rip it out, basically everything falls over without it.
The opencv-dnn module has been in digikam for several years.  At first, optional, then the default, and with version 7.2.0 the other alternative was ripped out.  Thus you cannot have facesengine without the opencv dnn.
So, let's look at opencv.
When RHEL8 was created out of Fedora, Fedora's opencv (3.4.1) had dnn turned off due to a dependency problem.  Thus, the RHEL version didn't have dnn turned on.
When RHEL8 updated opencv to 3.4.6, they left dnn off, possibly by accident, but at that time, the dependencies were not in RHEL 8 yet.
With RHEL 8.5 (or possibly 8.6) tesseract, the final dependency, will be in RHEL 8.

I have opened a bug to have opencv rebuilt, with the dnn libraries left in.
https://bugzilla.redhat.com/show_bug.cgi?id=2007780

Comment 7 Troy Dawson 2022-03-15 14:38:37 UTC
The new opencv that will be in RHEL 8.6 successfully builds the newer digikam.
I will be building digikam-7.3.0 (or newer) in epel8-next in the next week or two.  It will then make it to epel8 when RHEL8.6 is released.

Comment 8 Fedora Update System 2022-05-20 23:18:51 UTC
FEDORA-EPEL-NEXT-2022-5626a1e941 has been submitted as an update to Fedora EPEL 8 Next. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-NEXT-2022-5626a1e941

Comment 9 Fedora Update System 2022-05-21 02:29:03 UTC
FEDORA-EPEL-NEXT-2022-5626a1e941 has been pushed to the Fedora EPEL 8 Next testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-NEXT-2022-5626a1e941

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-05-29 01:12:09 UTC
FEDORA-EPEL-NEXT-2022-5626a1e941 has been pushed to the Fedora EPEL 8 Next stable repository.
If problem still persists, please make note of it in this bug report.