Bug 1991787

Summary: RFE: Please add the ability to build external nginx modules
Product: Red Hat Enterprise Linux 8 Reporter: Neal Gompa <ngompa13>
Component: nginx-1.20-moduleAssignee: Luboš Uhliarik <luhliari>
Status: CLOSED ERRATA QA Contact: icesalov
Severity: unspecified Docs Contact: Lenka Špačková <lkuprova>
Priority: unspecified    
Version: CentOS StreamCC: bnater, bstinson, carl, daxelrod, extras-qa, fedora, felix, gfialova, jeremy, jkaluza, jorton, jwboyer, luhliari, ollie.yeoh, pavel.lisy, peter.borsa, rhel-cs-infra-services-qe, wtogami
Target Milestone: betaKeywords: AutoVerified, FutureFeature, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nginx-1.20-8060020210910095205.d63f516d Doc Type: Enhancement
Doc Text:
.A new package: `nginx-mod-devel` A new `nginx-mod-devel` package has been added to the `nginx:1.20` module stream. The package provides all necessary files, including RPM macros and `nginx` source code, for building external dynamic modules for `nginx`.
 Story Points: ---
Clone Of: 1991720 Environment:
Last Closed: 2022-05-10 13:32:23 UTC Type: Enhancement
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Dist-Git patch to resolve this
none
Updated Dist-Git patch to resolve this none

Description Neal Gompa 2021-08-10 02:58:00 UTC 
+++ This bug was initially created as a clone of Bug #1991720 +++

Description of problem:
Nginx offers the ability to build external dynamic modules[1]; however, we don't have a way to do this in RHEL.

Please a -mod-devel package so that nginx modules can be built for nginx.

[1]: https://www.nginx.com/resources/wiki/extending/converting/#compiling-a-dynamic-module

Version-Release number of selected component (if applicable):
1.20.0-1.module+el8.5.0+10874+8aadcf3f
Comment 1 Neal Gompa 2021-08-10 03:06:52 UTC 
Created attachment 1812657 [details]
Dist-Git patch to resolve this

I've attached a patch to resolve this. It can be applied to the RHEL Dist-Git with "git am -p2".
Comment 2 Neal Gompa 2021-08-10 03:17:47 UTC 
I switched the component to make it clearer this is about the upcoming nginx-1.20 module.
Comment 3 Neal Gompa 2021-08-10 16:40:05 UTC 
Created attachment 1812808 [details]
Updated Dist-Git patch to resolve this

I've refreshed the patch to simplify the generator and make the macros match Fedora and EL9.
Comment 4 Neal Gompa 2021-08-13 11:05:49 UTC 
I've also filed this as a support case: https://access.redhat.com/support/cases/#/case/03007218
Comment 8 Luboš Uhliarik 2021-09-10 01:36:21 UTC 
Hi Neal,

I have already commited changes, so it should be synced soon with c8s.
Comment 9 Neal Gompa 2021-09-10 02:01:24 UTC 
(In reply to Luboš Uhliarik from comment #8)
> Hi Neal,
> 
> I have already commited changes, so it should be synced soon with c8s.

You committed the changes adding the -mod-devel package? Or just the --compat flag?
Comment 10 Branislav Náter 2021-09-10 07:43:42 UTC 
(In reply to Neal Gompa from comment #9)
> (In reply to Luboš Uhliarik from comment #8)
> > Hi Neal,
> > 
> > I have already commited changes, so it should be synced soon with c8s.
> 
> You committed the changes adding the -mod-devel package? Or just the
> --compat flag?

nginx-1.20 with --compat flag is already in c8s. This bug is about -mod-devel.
Comment 11 Neal Gompa 2021-09-10 18:38:44 UTC 
(In reply to Branislav Náter from comment #10)
> (In reply to Neal Gompa from comment #9)
> > (In reply to Luboš Uhliarik from comment #8)
> > > Hi Neal,
> > > 
> > > I have already commited changes, so it should be synced soon with c8s.
> > 
> > You committed the changes adding the -mod-devel package? Or just the
> > --compat flag?
> 
> nginx-1.20 with --compat flag is already in c8s. This bug is about
> -mod-devel.

Any chance we could also get bug 1991720 resolved for RHEL 9.0 too?
Comment 12 Branislav Náter 2021-09-12 08:59:00 UTC 
(In reply to Neal Gompa from comment #11)
> (In reply to Branislav Náter from comment #10)
> > (In reply to Neal Gompa from comment #9)
> > > (In reply to Luboš Uhliarik from comment #8)
> > > > Hi Neal,
> > > > 
> > > > I have already commited changes, so it should be synced soon with c8s.
> > > 
> > > You committed the changes adding the -mod-devel package? Or just the
> > > --compat flag?
> > 
> > nginx-1.20 with --compat flag is already in c8s. This bug is about
> > -mod-devel.
> 
> Any chance we could also get bug 1991720 resolved for RHEL 9.0 too?

Yes, we are planning to do so.
Comment 15 Luboš Uhliarik 2021-09-21 11:05:58 UTC 
Hi Neal,

this bug should be already merged in c8s. Please check it out.

https://git.centos.org/rpms/nginx/c/99dfe574fd6c460c2265a20982a831cbadb9d873?branch=c8s-stream-1.20
Comment 16 Neal Gompa 2021-09-21 12:34:20 UTC 
(In reply to Luboš Uhliarik from comment #15)
> Hi Neal,
> 
> this bug should be already merged in c8s. Please check it out.
> 
> https://git.centos.org/rpms/nginx/c/
> 99dfe574fd6c460c2265a20982a831cbadb9d873?branch=c8s-stream-1.20

Yep, I see it! I'm just waiting for it to be built and released in CentOS Stream 8 to test it out now.
Comment 17 Branislav Náter 2021-09-29 11:48:35 UTC 
(In reply to Neal Gompa from comment #16)
> (In reply to Luboš Uhliarik from comment #15)
> > Hi Neal,
> > 
> > this bug should be already merged in c8s. Please check it out.
> > 
> > https://git.centos.org/rpms/nginx/c/
> > 99dfe574fd6c460c2265a20982a831cbadb9d873?branch=c8s-stream-1.20
> 
> Yep, I see it! I'm just waiting for it to be built and released in CentOS
> Stream 8 to test it out now.

Hi Neal. Packages are present in c8s now [1]. Can you please let us know if everything works as expected and eventually provide us with test scenario?

1. http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/Packages/
Comment 18 Neal Gompa 2021-09-30 12:55:21 UTC 
(In reply to Branislav Náter from comment #17)
> (In reply to Neal Gompa from comment #16)
> > (In reply to Luboš Uhliarik from comment #15)
> > > Hi Neal,
> > > 
> > > this bug should be already merged in c8s. Please check it out.
> > > 
> > > https://git.centos.org/rpms/nginx/c/
> > > 99dfe574fd6c460c2265a20982a831cbadb9d873?branch=c8s-stream-1.20
> > 
> > Yep, I see it! I'm just waiting for it to be built and released in CentOS
> > Stream 8 to test it out now.
> 
> Hi Neal. Packages are present in c8s now [1]. Can you please let us know if
> everything works as expected and eventually provide us with test scenario?
> 
> 1. http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/Packages/

Everything seems to work as expected.

Here's a sample container I made for the purpose of testing it: https://pagure.io/nginx-vts-container

You can reproduce and verify this with either CentOS Stream 8 or Fedora and see it works. :)
Comment 29 errata-xmlrpc 2022-05-10 13:32:23 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nginx:1.20 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:1767