Bug 1992004

Summary:	ci/prow/e2e-gcp-console flake "Create Application from git form"
Product:	OpenShift Container Platform	Reporter:	David Taylor <dtaylor>
Component:	Dev Console	Assignee:	Christoph Jerolimov <cjerolim>
Status:	CLOSED ERRATA	QA Contact:
Severity:	high	Docs Contact:
Priority:	medium
Version:	4.9	CC:	aos-bugs, cjerolim, nmukherj
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1992013 (view as bug list)		Environment:
Last Closed:	2021-10-18 17:45:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Taylor 2021-08-10 14:24:21 UTC

Seeing continous flakes for dev console's /frontend/packages/dev-console/integration-tests/features/addFlow/create-from-git.feature

"# Create Application from git form.Create Application from git form Add new git workload with new application for resoruce type "Deployment": A-06-TC01 (example #1)
AssertionError: Timed out retrying after 40000ms: Expected to find element: `[aria-label="Perl"]`, but never found it."

"# Create Application from git form.Create Application from git form Add new git workload with new application for resoruce type "Deployment": A-06-TC01 (example #1)
AssertionError: Timed out retrying after 40000ms: Expected to find element: `[role="listbox"]`, but never found it."

https://search.ci.openshift.org/?search=Create+Application+from+git+form&maxAge=168h&context=1&type=junit&name=pull-ci-openshift-console-master-e2e-gcp-console&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

`[aria-label="Perl"]` and `[role="listbox"]` seem to be the primary selectors having issues.


This may be addressed/affected by work currently being done to update the Project Dropdown being used in these tests:
https://github.com/openshift/console/pull/9279
https://github.com/patternfly/patternfly-react/pull/6152

Comment 1 David Taylor 2021-08-11 13:21:23 UTC

It appears that there is no longer `aria-labels` on the 'Perl', 'Nginx', etc. tiles shown in the 'add from git' flow.  We need to determine if this is a PR regression or in the dev console code.

Comment 3 David Taylor 2021-08-11 16:47:54 UTC

We seem to get the "Expected to find element: `[aria-label="Perl"]`, but never found it." error when after user enters Git Repo url as "https://github.com/sclorg/dancer-ex.git" which then calls 'verifyValidateMessage' which IF there is a warning alert around the url input field (which there is when flake happens), will then call 'gitPage.selectBuilderImageForGitUrl(gitUrl)' (which tests for the `aria-label`).  Please see attachment 1813209 [details] "create-from-git.feature:  Warning Alert"

I regressed my local branch to before latest PF update (https://github.com/openshift/console/pull/9717) and still do not see aria-labels for the 'add from git' tiles, 'gitPage.selectBuilderImageForGitUrl(gitUrl)' is checking for, so I'm not sure when it stopped working.

https://github.com/openshift/console/blob/d79b408af3509c7eb3ec0d63f591cc381df92e84/frontend/packages/dev-console/integration-tests/support/pages/add-flow/git-page.ts#L244
https://github.com/openshift/console/blob/d79b408af3509c7eb3ec0d63f591cc381df92e84/frontend/packages/dev-console/integration-tests/support/pages/add-flow/git-page.ts#L176

Comment 4 Christoph Jerolimov 2021-08-12 09:35:57 UTC

Provided a bugfix for `[aria-label="Perl"]`

The `[role="listbox"]` issue looks related to our new project dropdown and should be checked in that PRs. I think this should be fixed by cherry-picking this commit https://github.com/openshift/console/pull/9767/commits/2c2132c9fe3985505176f7c41299c60f8fbc21d9

Comment 6 Christoph Jerolimov 2021-08-27 17:15:29 UTC

Mark this as verified because this affects only our automated tests and the issue is not reopened in the last two weeks.

Comment 10 errata-xmlrpc 2021-10-18 17:45:44 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759