Bug 1992599

Summary:	Allow to set the "full-pcpus-only" cpumanager static policy option
Product:	OpenShift Container Platform	Reporter:	Francesco Romani <fromani>
Component:	Machine Config Operator	Assignee:	MCO Team <team-mco>
Machine Config Operator sub component:	Machine Config Operator	QA Contact:	Rio Liu <rioliu>
Status:	CLOSED NOTABUG	Docs Contact:
Severity:	unspecified
Priority:	unspecified	CC:	aos-bugs, mkrejci, skumari
Version:	4.9
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-22 16:37:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Francesco Romani 2021-08-11 11:48:55 UTC

Description of problem:
Kubernetes 1.22 gained the support for cpumanager static policy options (https://github.com/kubernetes/kubernetes/blob/v1.22.0/pkg/kubelet/cm/cpumanager/policy_options.go#L26) . We would like to (conditionally) enable the "full-cpupus-only" option in the performance addon operator. To allow that, we will however need to enable the "CPUManagerPolicyOptions" feature gate (https://github.com/kubernetes/kubernetes/blob/v1.22.0/pkg/features/kube_features.go#L792)

Version-Release number of selected component (if applicable):
4.9

How reproducible:
Always

Steps to Reproduce:
1. Try to enable the feature gate
2. MCO will refuse the update

Actual results:
Is not possible to enable the feature gate

Expected results:
It should be possible to enable the feature gate

Comment 1 Francesco Romani 2021-08-11 11:59:06 UTC

AFAIU, once the `openshift/api` PR lands, on MCO side it should be enough to bump the `openshift/api` go module dep. I'd be happy to provide both PRs myself.

Comment 2 Yu Qi Zhang 2021-08-12 03:03:20 UTC

Quick question, is this associated with https://github.com/openshift/machine-config-operator/pull/2685 ?

Comment 3 Francesco Romani 2021-08-12 05:55:27 UTC

(In reply to Yu Qi Zhang from comment #2)
> Quick question, is this associated with
> https://github.com/openshift/machine-config-operator/pull/2685 ?

Not that I'm aware of. I didn't push a PR to MCO yet.

Comment 4 Sinny Kumari 2021-11-22 16:37:39 UTC

We see that it didn't mad into kube 1.22 and we are targeting kube 1.23. Also considering this is a feature and not a bug, we are closing this. Please open a jira card against MCO board once you plan to work on it and need our review.