Bug 1993294
| Summary: | Review Request: rust-base-x - Encode/decode any base | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-08-17 13:44:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2021-08-12 17:42:04 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73735671 The .spec file behind the link and the file inside the SRPM are different, please make sure they're consistent:
Diff spec file in url and in SRPM
---------------------------------
--- /home/deca/Downloads/1993294-rust-base-x/srpm/rust-base-x.spec 2022-01-21 23:05:08.016351250 +0100
+++ /home/deca/Downloads/1993294-rust-base-x/srpm-unpacked/rust-base-x.spec 2021-08-12 19:32:42.000000000 +0200
@@ -82,5 +82,5 @@
%if %{with check}
%check
-%cargo_test -- -- --skip test::range::read_range tests::connect_http_google tests::connect_https_google
+%cargo_test
%endif
And if you need to disable tests, please add a descriptive comment in the line above, something like
"# * skip tests that require internet connectivity"
Good catch! Not sure how that ended up there, but it's not needed. Spec URL: https://dcavalca.fedorapeople.org/review/rust-base-x/rust-base-x.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-base-x/rust-base-x-0.2.8-1.fc37.src.rpm Changelog: - re-run rust2rpm - drop unnecessary test gate - link to upstream PR Upstream has released two new versions, could you update this to version 0.2.10 and refresh the spec with rust2rpm 21, if you're still interested in packaging it? Spec URL: https://dcavalca.fedorapeople.org/review/rust-base-x/rust-base-x.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-base-x/rust-base-x-0.2.11-1.fc38.src.rpm Changelog: - re-run rust2rpm - update to 0.2.11 Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Thanks! $ fedpkg request-repo rust-base-x 1993294 https://pagure.io/releng/fedora-scm-requests/issue/46487 $ fedpkg request-branch --repo rust-base-x f37 https://pagure.io/releng/fedora-scm-requests/issue/46489 $ fedpkg request-branch --repo rust-base-x f36 https://pagure.io/releng/fedora-scm-requests/issue/46490 $ fedpkg request-branch --repo rust-base-x f35 https://pagure.io/releng/fedora-scm-requests/issue/46491 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-base-x FEDORA-2022-32d79722b1 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-32d79722b1 FEDORA-2022-32d79722b1 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-2a59a4e672 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2a59a4e672 FEDORA-2022-2a59a4e672 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-38b8ae4e06 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-38b8ae4e06 FEDORA-2022-104339afb6 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-104339afb6 FEDORA-2022-38b8ae4e06 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-38b8ae4e06 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-38b8ae4e06 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-104339afb6 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-104339afb6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-104339afb6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-104339afb6 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-38b8ae4e06 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |