Bug 1993445

Summary: NFD Operator - Serviceaccount for nfd-instance degraded
Product: OpenShift Container Platform Reporter: jschinta
Component: Multi-ArchAssignee: jschinta
Status: CLOSED WORKSFORME QA Contact: Douglas Slavens <dslavens>
Severity: low Docs Contact:
Priority: low    
Version: 4.9CC: danili
Target Milestone: ---   
Target Release: ---   
Hardware: s390x   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-12-07 16:28:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1980363    

Description jschinta 2021-08-13 07:04:48 UTC
Description of problem:
When deploying the NFD Operator in OCP from OLM and creating the nfd-instance, the status Shows NFDServiceAccountDegraded. NFD works without problems.

From the Pod Log:

2021-08-12T12:16:18.728Z        ERROR   controller-runtime.manager.controller.nodefeaturediscovery      Reconciler error        {"reconciler group": "nfd.openshift.io", "reconciler kind": "N
odeFeatureDiscovery", "name": "nfd-instance", "namespace": "openshift-operators", "error": "NFDServiceAccountDegraded"}
github.com/go-logr/zapr.(*zapLogger).Error
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/github.com/go-logr/zapr/zapr.go:132
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:267
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:235
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.1
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:198
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:185
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:185
k8s.io/apimachinery/pkg/util/wait.UntilWithContext
        /go/src/github.com/openshift/cluster-nfd-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:99

Version-Release number of selected component (if applicable):
NFD 4.9.0-202107210242
OCP 4.9.0-0.nightly-s390x-2021-08-04-204925

How reproducible:
Install NFD from OLM and create the nfd-instance

Steps to Reproduce:
1.
2.
3.

Actual results:
Error shown for serviceaccount for nfd-instance

Expected results:
No Errors

Additional info:
I don't think there should be a serviceaccount for the custom resource.
The 3 serviceaccount for operator, master and worker respectevly are created and fine.

Comment 1 Dan Li 2021-08-13 14:56:03 UTC
Setting reviewed-in-sprint as this bug is new and untriaged and therefore unlikely to complete before the end of the current sprint

Comment 2 Dan Li 2021-09-15 19:08:23 UTC
Hi @Carvel, just a mid-sprint note that this story is currently committed for this sprint. Thank you!

Comment 3 Dan Li 2021-09-20 18:28:35 UTC
Hi Carvel, do you think this bug will continued to be looked at in the next sprint? If so, I'd like to add a "reviewed-in-sprint" flag to indicate that we examined the bug this sprint.

Comment 4 Carvel Baus 2021-09-21 13:26:04 UTC
It is possible. Will set reviewed-in-sprint.

Comment 5 Dan Li 2021-10-27 12:16:25 UTC
Taking this bug as a part of bug triage in the interim.

Comment 6 Dan Li 2021-11-04 19:35:36 UTC
Assigning to Jan and adding reviewed-in-sprint

Comment 7 Dan Li 2021-11-22 21:15:21 UTC
Hi Jan, do you think this bug will continue to be open after this sprint (November 27th)? If so, I'd like to set "reviewed-in-sprint" to indicate that it will be worked on in a future sprint.

Comment 8 jschinta 2021-11-23 08:00:35 UTC
Hi Dan,
i'm planning to start working on this next sprint. Please set the "reviewed-in-sprint" flag.

Comment 9 jschinta 2021-12-07 16:28:02 UTC
Checking out this bug it seems that it has already been fixed in the latest version of the operator. I can confirm that the issue no longer exists in the latest 4.9 and 4.10 operators.

I tested it with:
NFD-Operator 4.9.0-202111171831
OCP          4.9.8

and

NFD-Operator 4.10.0-202112031620
OCP          4.10.0-0.nightly-s390x-2021-12-02-191354

As it is already fixed i can't say anything to the cause, but i think it was likely fixed by this commit https://github.com/openshift/cluster-nfd-operator/commit/c85f9aeed664f6be9f969b604db279d2d64c033e
which reworked how the status is assessed.