Bug 1993472

Summary:	Review Request: rust-mockall_double - Test double adapter for Mockall
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	davide, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-27 16:24:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1993474

Description Fabio Valentini 2021-08-13 10:56:48 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-mockall_double.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-mockall_double-0.2.0-1.fc34.src.rpm

Description:
Test double adapter for Mockall.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-08-13 10:56:51 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=73775448

Comment 2 Davide Cavalca 2021-08-26 04:41:33 UTC

Taking this review

Comment 3 Davide Cavalca 2021-08-26 04:45:42 UTC

Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- License is correct and valid
- Only sources installed
- Latest version packaged
- Package builds fine in Rawhide
- Consider switching to rpmautospec on import to ease future maintenance

PACKAGE APPROVED.

Comment 4 Fabio Valentini 2021-08-26 10:42:21 UTC

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/36533
https://pagure.io/releng/fedora-scm-requests/issue/36534
https://pagure.io/releng/fedora-scm-requests/issue/36535

Comment 5 Tomas Hrcka 2021-08-26 11:45:29 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-mockall_double

Comment 6 Fedora Update System 2021-08-27 16:24:23 UTC

FEDORA-2021-9cc8bc3dc1 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.