Bug 1994065

Summary:	Review Request: nginx-mod-vts - Nginx virtual host traffic status module
Product:	[Fedora] Fedora	Reporter:	Neal Gompa <ngompa13>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	davide, daxelrod, fedora, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-26 21:07:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Neal Gompa 2021-08-16 15:58:26 UTC

Spec URL: https://ngompa.fedorapeople.org/for-review/nginx-mod-vts.spec
SRPM URL: https://ngompa.fedorapeople.org/for-review/nginx-mod-vts-0.1.18-1.fc34.src.rpm

Description:
Nginx virtual host traffic status module.

Fedora Account System Username: ngompa

Comment 1 Davide Cavalca 2021-08-16 16:04:57 UTC

- build fails due to missing nginx-mod-devel
- use install -p to preserve timestamps

Comment 2 Neal Gompa 2021-08-16 16:12:08 UTC

(In reply to Davide Cavalca from comment #1)
> - build fails due to missing nginx-mod-devel

You either need to use local repo with Rawhide or have updates-testing enabled on F33 or F34.

> - use install -p to preserve timestamps

There's only one file being "installed", the rest is using "install" to create directories. The .so file is already being done this way.

Comment 3 Davide Cavalca 2021-08-16 16:19:18 UTC

Review notes:

- Packaging follows naming guidelines
- Package licensing is indicated correctly
- Packaging builds and installs (when dependencies are installed and pre-populated in the chroot)
- No issues from rpmlint

PACKAGE APPROVED.

Comment 4 Gwyn Ciesla 2021-08-16 16:36:19 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nginx-mod-vts

Comment 5 Fedora Update System 2021-08-18 05:30:24 UTC

FEDORA-2021-8471f47319 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8471f47319

Comment 6 Fedora Update System 2021-08-18 05:30:25 UTC

FEDORA-2021-e0c54f34c4 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e0c54f34c4

Comment 7 Fedora Update System 2021-08-19 01:42:13 UTC

FEDORA-2021-8471f47319 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8471f47319 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8471f47319

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-08-19 01:51:56 UTC

FEDORA-2021-e0c54f34c4 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e0c54f34c4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e0c54f34c4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-08-26 21:07:31 UTC

FEDORA-2021-8471f47319 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2021-08-26 21:10:02 UTC

FEDORA-2021-e0c54f34c4 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.