Bug 199409

Summary: ppmtompeg -- double call of fclose() on a single FILE * raising glibc exception
Product: [Fedora] Fedora Reporter: Milan Zázrivec <mzazrivec>
Component: netpbmAssignee: Jindrich Novy <jnovy>
Status: CLOSED RAWHIDE QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: pknirsch
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-07-19 13:18:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
NetPBM double fclose() patch none

Description Milan Zázrivec 2006-07-19 12:39:08 UTC
Description of problem:

When running ppmtompeg in parallel mode, Combine server tries
to fclose single *FILE structure twice.

Version-Release number of selected component (if applicable):

10.33, 10.34, most-likely in previous versions too.

How reproducible:

Run ppmtompeg in parallel mode.

Steps to Reproduce:
1. run ppmtompeg in parallel mode
2. after combine server shut down, glibc reports 
   'double free or corruption error'
  
Actual results:
glibc error report:

*** glibc detected ***
/usr/src/redhat/BUILD/netpbm-10.33/converter/ppm/ppmtompeg/ppmtompeg: double
free or corruption (fasttop): 0x08d5f0f0 ***
======= Backtrace: =========
/lib/libc.so.6[0x174f18]
/lib/libc.so.6(__libc_free+0x78)[0x1783ef]
/lib/libc.so.6(fclose+0x140)[0x1654c0] ... report continues.

glibc error mentioned above causes combine server to exit uncleanly,
but it does not affect encoded mpeg-file in any way, as it is already 
flushed and closed.

Attached patch solves this problem.

Comment 1 Milan Zázrivec 2006-07-19 12:39:08 UTC
Created attachment 132678 [details]
NetPBM double fclose() patch

Comment 2 Jindrich Novy 2006-07-19 13:18:13 UTC
Fixed since 10.34-2.

Thanks.

Comment 3 Fedora Update System 2006-08-14 15:59:00 UTC
netpbm-10.34-1.fc5 has been pushed for fc5, which should resolve this issue.  If these problems are still present in this version, then please make note of it in this bug report.