Bug 1994898

Summary:	[RFE] Adding and removing VM's host devices for cockpit-machines
Product:	Red Hat Enterprise Linux 9	Reporter:	Xianghua Chen <xchen>
Component:	cockpit-machines	Assignee:	Simon Kobyda <skobyda>
Status:	CLOSED ERRATA	QA Contact:	Xianghua Chen <xchen>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.0	CC:	kkoukiou, mmarusak, skobyda, wshi, ymao, yunyang
Target Milestone:	beta	Keywords:	FutureFeature
Target Release:	9.0	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-17 12:44:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xianghua Chen 2021-08-18 06:32:18 UTC

Description of problem:
[RFE] Adding and removing VM's host devices for cockpit-machines

Version-Release number of selected component (if applicable):
cockpit-machines-249-1.el9.noarch
libvirt-dbus-1.4.1-4.el9.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Matej Marušák 2021-08-18 06:41:47 UTC

This is being worked on in upstream in https://github.com/cockpit-project/cockpit-machines/pull/226

Comment 4 Simon Kobyda 2021-10-29 11:45:06 UTC

Yes this indeed is fixed and in released version of cockpit-machines

Comment 5 Xianghua Chen 2021-11-01 06:37:03 UTC

Preverified with package:
cockpit-machines-254-1.el9.noarch
libvirt-dbus-1.4.1-5.el9.x86_64
cockpit-255-1.el9.x86_64

Steps:
1. Prepare a shut off vm, enter vm details page
2. Click "Add host device", there will be a dialog showing up, Type "USB", choose a usb device and click Add
3. Check xml by:
# virsh dumpxml cirros | grep -iC 5 hostdev
There is usb device related:
    <hostdev mode='subsystem' type='usb' managed='yes'>
      <source>
        <vendor id='0x1d6b'/>
        <product id='0x0001'/>
        <address bus='6' device='1'/>
      </source>
      <alias name='hostdev0'/>
      <address type='usb' bus='0' port='1'/>
    </hostdev>
4. Remove it, check the xml again.
5. Choose "PCI" as type, and choose a Audio or Graphic device then click Add
6. Check xml by:
# virsh dumpxml cirros | grep -iC 5 hostdev
There is xml info like:
    <hostdev mode='subsystem' type='pci' managed='yes'>
      <source>
        <address domain='0x0000' bus='0x00' slot='0x1b' function='0x0'/>
      </source>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
    </hostdev>
7. Remove it, check the xml again.


There is one bug occurs occasionally, open another bug for it Bug2018448.
But as the basic functions are ok here, So pre-verified.

Comment 8 Xianghua Chen 2021-12-17 13:10:25 UTC

Verified with pakages:
cockpit-machines-258.1-1.el9.noarch
libvirt-dbus-1.4.1-5.el9.x86_64
cockpit-258-1.el9.x86_64

Steps:
1. Prepare a shut off vm, enter vm details page
2. Click "Add host device", there will be a dialog showing up, Type "USB", choose a usb device and click Add
3. Check xml by:
# virsh dumpxml cirros | grep -iC 5 hostdev
There is usb device related.
4. Remove it, check the xml again.
5. Choose "PCI" as type, and choose a Audio or Graphic device then click Add
6. Check xml by:
# virsh dumpxml cirros | grep -iC 5 hostdev
There is pci device related.
7. Remove it, check the xml again. 

Verified as basic functions ok, track Bug2018448 for other issue related.

Comment 10 errata-xmlrpc 2022-05-17 12:44:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: cockpit-machines), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2388