Bug 1994946

Summary:	Review Request: rust-pyo3-build-config - Build configuration for the PyO3 ecosystem
Product:	[Fedora] Fedora	Reporter:	Christian Heimes <cheimes>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-24 11:41:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christian Heimes 2021-08-18 08:29:20 UTC

Spec URL: https://cheimes.fedorapeople.org/rust/rust-pyo3-build-config.spec
SRPM URL: https://cheimes.fedorapeople.org/rust/rust-pyo3-build-config-0.14.2-1.fc34.src.rpm
Description: Build configuration for the PyO3 ecosystem
Fedora Account System Username: cheimes

Comment 1 Christian Heimes 2021-08-18 08:30:26 UTC

rust-pyo3-build-config is a build dependency of rust-pyo3-macros-backend and ultimately of rust-pyo3.

Comment 2 Fabio Valentini 2021-08-20 17:00:27 UTC

Taking this review.

The package was generated with rust2rpm, simplifying the review:

- latest version is packaged
- package builds and installs without errors on Fedora rawhide
- test suite is run and all tests pass
- license matches upstream specification and is acceptable for Fedora
- ASL 2.0 LICENSE license file is included with %license and installed in all cases
- package conforms to Rust packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2021-08-20 17:08:21 UTC

Please also don't forget the usual "post-review" tasks for rust-sig packages:

- request repo and f35 branch (and f34, if you need pyo3 0.14 there too),
- add "@rust-sig" to the package with "commit" access,
- set default bugzilla assignee to "@rust-sig" (optional),
- set up release-monitoring.org for pyo3-build-config,
- add package to koschei for all branches where it will be built.

You can look at  https://release-monitoring.org/project/141649/ for how a similar project is set up in release-monitoring.org (in particular, using "semantic" versioning option works much better for Rust projects than the other two options).

Comment 4 Gwyn Ciesla 2021-08-23 13:54:15 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pyo3-build-config

Comment 5 Fedora Update System 2021-08-24 11:41:27 UTC

FEDORA-2021-3ea73eb97f has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.