Bug 1995309

Summary:	Review Request: cri-tools - CLI and validation tools for Container Runtime Interface
Product:	[Fedora] Fedora	Reporter:	Peter Hunt <pehunt>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	maxwell, ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	cri-tools-1.24.2-1.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-19 20:37:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peter Hunt 2021-08-18 19:17:34 UTC

Spec URL: https://haircommander.fedorapeople.org/cri-o.spec
SRPM URL: https://haircommander.fedorapeople.org/cri-o-1.21.2-1.fc32.src.rpm
Description: CLI and validation tools for Container Runtime Interface
Fedora Account System Username: haircommander

Comment 1 Peter Hunt 2021-08-18 19:19:15 UTC

copy pasta errors :facepalm:
Spec URL: https://haircommander.fedorapeople.org/cri-tools.spec
SRPM URL: https://haircommander.fedorapeople.org/cri-tools-1.21.0-1.fc32.src.rpm

Comment 2 Neal Gompa 2021-08-20 03:09:24 UTC

Taking this review.

Comment 3 Neal Gompa 2021-08-20 03:10:49 UTC

> #define license tag if not already defined
> %{!?_licensedir:%global license %doc}

There are no supported RHEL or Fedora versions where this is necessary, so it can be dropped.

Comment 4 Peter Hunt 2021-08-20 14:53:26 UTC

Adapted as suggested :)

Comment 5 Neal Gompa 2021-08-26 20:16:54 UTC

Review notes:

* Package complies with Fedora Packaging Guidelines
* Package complies (mostly) with Go packaging guidelines
* Package builds and installs
* Package has correct licensing and license files are installed
* No serious issues from rpmlint

We're good here, so...

PACKAGE APPROVED.