Bug 1995380

Description of the problem:

When there is a failure to provision a cluster via a ClusterPool, the UI presents a spinner with the word "Creating" indefinitely. Clicking the link to logs has no effect due to non-existent hive pod.

Release version: 2.3.1

Operator snapshot version:

OCP version: 4.8.4

Browser Info: Chrome

Steps to reproduce:
1. Create clusterpool with invalid Azure region spelling
2. Create install-config.yaml for same with proper Azure region spelling


Actual results:

UI gives impression that cluster creation is proceeding when it never actually started.

Expected results:

The error condition found in the ClusterDeployment should be surfaced to the ClusterPool UI and cluster creation should fail.

Additional info:
https://coreos.slack.com/archives/CTZTHFQRH/p1629327600047100


Inputs:
---
apiVersion: hive.openshift.io/v1
kind: ClusterPool
metadata:
  name: az-edge-bad
  namespace: edge-pool
  labels:
    cluster.open-cluster-management.io/clusterset: edge
    cloud: Azure
    region: badvalue
    vendor: OpenShift
spec:
  baseDomain: az.domain.com
  imageSetRef:
    name: img4.8.4-x86-64-appsub
  skipMachinePools: true
  installConfigSecretTemplateRef:
    name: az-install-config
  platform:
    azure:
      baseDomainResourceGroupName: ocp
      credentialsSecretRef:
        name: azure-creds
      region: badvalue
  pullSecretRef:
    name: pull-secret
  size: 2

---
apiVersion: v1
baseDomain: az.domain.com
compute:
- architecture: amd64
  hyperthreading: Enabled
  name: worker
  platform: {}
  replicas: 0
controlPlane:
  architecture: amd64
  hyperthreading: Enabled
  name: master
  platform: {}
  replicas: 1
metadata:
  creationTimestamp: null
  name: edge
networking:
  clusterNetwork:
  - cidr: 10.128.0.0/14
    hostPrefix: 23
  machineNetwork:
  - cidr: 10.0.0.0/16
  networkType: OVNKubernetes
  serviceNetwork:
  - 172.30.0.0/16
platform:
  azure:
    baseDomainResourceGroupName: ocp
    cloudName: AzurePublicCloud
    outboundType: Loadbalancer
    region: westus2
publish: External
pullSecret: "" 


Resulting ClusterDeployment:

status:
  cliImage: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:c7210ebe8b9c7b0799b4188be59bb712e50e1e26a28e0dfa4c7b6f4e9745a1c7
  conditions:
  - lastProbeTime: "2021-08-18T23:25:52Z"
    lastTransitionTime: "2021-08-18T23:25:52Z"
    message: install config region does not match cluster deployment region
    reason: InstallConfigValidationFailed
    status: "False"
    type: RequirementsMet