Bug 1995519

Summary: Improve CPU count handling in VM edit dialog
Product: [oVirt] ovirt-engine Reporter: Milan Zamazal <mzamazal>
Component: Frontend.WebAdminAssignee: Lucia Jelinkova <ljelinko>
Status: CLOSED WONTFIX QA Contact: meital avital <mavital>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.4.8.4CC: ahadas, bugs
Target Milestone: ---Flags: sbonazzo: ovirt-4.5-
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-18 12:28:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Milan Zamazal 2021-08-19 10:15:21 UTC 
Description of problem:

The CPU count handling is somewhat confused in the VM edit dialog:

- "Total Virtual CPUs" field considers the limit from configuration but doesn't consider i440fx limits. If i440fx chipset is selected together with too many CPUs for that chipset (e.g. 300), the error is reported only after the edit dialog is closed. The error is confusing and the changed settings are lost.
- When "Total Virtual CPUs" field is changed and then "Custom Compatibility Version" is changed in the same dialog run, "Total Virtual CPUs" is reset to its original value.

There may be other similar problems there. It would be nice to revise and clean up the checks and updates on the number of CPUs in the dialog.

Version-Release number of selected component (if applicable):

4.4.8

How reproducible:

100%
Comment 1 Arik 2022-04-04 11:34:02 UTC 
(In reply to Milan Zamazal from comment #0)
> - "Total Virtual CPUs" field considers the limit from configuration but
> doesn't consider i440fx limits. If i440fx chipset is selected together with
> too many CPUs for that chipset (e.g. 300), the error is reported only after
> the edit dialog is closed. The error is confusing and the changed settings
> are lost.

This part should be relatively easy to do and it makes sense

> - When "Total Virtual CPUs" field is changed and then "Custom Compatibility
> Version" is changed in the same dialog run, "Total Virtual CPUs" is reset to
> its original value.

This part might have been solved by a recent change that prevented a race between setting the CPU count and setting the template (but it might also happen with the custom compatibility version field). If not, that's not so interesting - setting custom compatibility version is not a common case
Comment 2 Milan Zamazal 2022-07-18 12:28:25 UTC 
Not of high importance, closing due to insufficient capacity.