Bug 1996128

Summary:	fix incorrect dual-stack podCIDR e2e test
Product:	OpenShift Container Platform	Reporter:	Dan Winship <danw>
Component:	Networking	Assignee:	Riccardo Ravaioli <rravaiol>
Networking sub component:	ovn-kubernetes	QA Contact:	Anurag saxena <anusaxen>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	aojeagar, rravaiol, vlaad
Version:	4.9	Flags:	rravaiol: needinfo-
Target Milestone:	---
Target Release:	4.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-08 05:41:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Winship 2021-08-20 15:53:18 UTC

The test

  [sig-network] [Feature:IPv6DualStack] should have ipv4 and ipv6 node podCIDRs [LinuxOnly]

incorrectly assumes that all clusters (except Windows ones) use --allocate-node-cidrs, and so fails under OCP where we do not use that.

What the test probably should do is, *if* the single-stack podCIDR field is set on a node, then require that podCIDRs is also set, and correct. (And if podCIDR is unset, then podCIDRs should be unset too.)

And then the `[LinuxOnly]` can be removed because it should never have been there in the first place; they were just working around the bug incorrectly.

Comment 1 Antonio Ojea 2021-08-24 08:00:43 UTC

That test should have moved out of the e2e framework since podCIDR is not mandatory.
I rather prefer to remove it than to add more conditions to the test ... and move it as an integration or unit test in the controller manager if we don't want to loose coverage.

Comment 2 Riccardo Ravaioli 2021-09-16 10:27:05 UTC

For the sake of tracking, here's the link to the discussion opened by Antonio in upstream kubernetes on this issue: https://github.com/kubernetes/kubernetes/issues/104544

Comment 3 Dan Winship 2021-09-21 11:31:00 UTC

The test was removed upstream (https://github.com/kubernetes/kubernetes/pull/105079) so the skip rule can be removed once origin is rebased to kube 1.23.

Comment 12 errata-xmlrpc 2022-09-08 05:41:12 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.10.31 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6258