Bug 199627

Created attachment 132846 [details]
Patch to fix rpmlint warning on the srpm.

Patch fixes the following warning:
W: kooldock mixed-use-of-spaces-and-tabs

BTW, the package builds cleanly on FC5 and rpmlint gives no errors for the rpm.

(In reply to comment #2)
> BTW, the package builds cleanly on FC5 and rpmlint gives no errors for the 
rpm.

Now I know, why I haven't noticed mixed-use-of-spaces-and-tabs warning...
Because I always use it to rpm, never to srpm.

I've sent new inital release of SPEC and SRPM files:
Spec URL: http://ecik.zspswidwin.pl/kooldock/kooldock.spec
SRPM URL: http://ecik.zspswidwin.pl/kooldock/kooldock-0.3-1.20060720cvs.src.rpm

Removing FE-NEEDSPONSOR as MichaÅ has been sponsored.

A few more comments:
* I think you should change Source0 to use %{name} instead of kooldock. 
* The same is valid for the line beginning with %setup
* You should use cvs_date macro in Source0
* You should add  %{?smp_flags} to make in %prep

That is all I can see now. Per Review Guidelines, I tried to test everything
except mock build.

Regards, Devrim

New URLs:

Spec URL: http://ecik.zspswidwin.pl/kooldock/kooldock.spec
SRPM URL: http://ecik.zspswidwin.pl/kooldock/kooldock-0.3-2.20060720cvs.src.rpm

I can review this...

Grr. http://ktown.kde.cl/kooldock/ seems unreachable atm, I'll try again 
later.

Well, I don't think this site will be available at any time. It looks dead for
a long time.

1.  %prep: the rm should come *after* the %setup, else, there's nothing 
there/unpackage yet to delete.

2.  drop hard-coded
Requires: kdelibs

3.  If this is a cvs snapshot prerelease, Release tag should be prefixed with 
0. so use something like this instead:
Release: 0.2.%{cvs_date}cvs%{?dist}

4.  The bit in %build
export QTLIB...
isn't needed anymore to workaround qt bug(s).  The bugs have been fixed.

5.  Drop 
%doc INSTALL
no need for INSTALL instructions here. (:

6.  Since you're installing icons, you should include scriptlets:
%post
touch --no-create %{_datadir}/icons/crystalsvg || :

%postun
touch --no-create %{_datadir}/icons/crystalsvg || :

7. You probably ought to change
%defattr(0644,root,root,0755)
to
%defattr(-,root,root,-)
then you won't need the %attr bits for:
%attr(0755,root,root)%{_bindir}/*

8. Upstream source.  If you're going to be using a cvs checkout, please provide 
a script to (re)generate said source tarball.

>Well, I don't think this site will be available at any time. It looks dead for
>a long time.

Then I suggest you find a better/working site use for
URL:

(In reply to comment #11)

> 3.  If this is a cvs snapshot prerelease, Release tag should be prefixed with 
> 0. so use something like this instead:
> Release: 0.2.%{cvs_date}cvs%{?dist}

This is POSTrelease.

> 8. Upstream source.  If you're going to be using a cvs checkout, please 
provide 
> a script to (re)generate said source tarball.

Could you explain me what do you exactly mean?

URLs:
SPEC URL: http://ecik.zspswidwin.pl/kooldock/kooldock.spec
SRPM URL: http://ecik.zspswidwin.pl/kooldock/kooldock-0.3-3.20060720cvs.src.rpm

> This is POSTrelease.

Then never mind, no need to use a 0. prefex.

>> a script to (re)generate said source tarball.

> Could you explain me what do you exactly mean?

Include
Source1: kooldock-cvs_checkout.sh
that contains (something like):
----------------------------------
#!/bin/bash
MODULE=$(basename $0 -cvs_checkout.sh)
DATE=$(date +%Y%m%d)

set -x
rm -rf $MODULE
cvs -z3 -d:pserver:anonymous@${MODULE}.cvs.sourceforge.net:/cvsroot/$MODULE co
-P $MODULE
tar cjf $MODULE-${DATE}cvs.tar.bz2 $MODULE
rm -rf $MODULE
--------------------------

There is no need to it. As I wrote in my first comment, project is dead
and will never be continued. The last change in CVS is two years old.
I have done one cvs snapshot on my server and this is enough.

> As I wrote in my first comment, project is dead
> and will never be continued.

My bad for missing that, sorry.

With upstream project being dead, it's ill-advised to bring this into Extras. 
I'm not willing to approve this. 

(In reply to comment #16)
> With upstream project being dead, it's ill-advised to bring this into Extras. 
> I'm not willing to approve this. 

I reported this package, because despite of its dead it still looks nice and 
works nice and, for me, it is the greatest docker for KDE.

In reply to #17

>I reported this package, because despite of its dead it still looks nice and 
>works nice and, for me, it is the greatest docker for KDE.

Then the solution is obvious, you should become the upstream source maintainer 
for this package.

(In reply to comment #18)
> Then the solution is obvious, you should become the upstream source 
maintainer 
> for this package.

I am. I've done my own cvs snapshot and this package uses it.

Fair enough, game on.

Michal, the package looks in pretty good shape, now for some testing...

Why have you added FE-NEEDSPONSOR block? I'm already sponsored and I'm owner
of kadu and python-mutagen packages.

Because I'm lame and read comment #1 that said you were looking for a sponsor, 
and *assumed*... (:

(In reply to comment #23)
> Because I'm lame and read comment #1 that said you were looking for a 
sponsor, 
> and *assumed*... (:

Never mind ;)
So, what with approvement this package to extras?

looks good, APPROVED.

Don't forget to close this bug once you've imported and submitted a build.

Closing it.