Bug 1996323
| Summary: | Pass missing dep on wl-clipboard | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | pass | Assignee: | Christophe Fergeau <cfergeau> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | carl, cfergeau, deekej, dominik, jkonecny, maxwell, pingou, raphael.kubo.da.costa |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | pass-1.7.4-3.fc36 pass-1.7.4-3.fc35 pass-1.7.4-3.fc33 pass-1.7.4-2.fc34 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-11-12 00:38:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jerry James
2021-08-21 20:27:25 UTC
The Requires is there as a conditional one: $ dnf repoquery --requires pass-1.7.4-1.fc34.noarch (xclip or wl-clipboard) [snip] However, this does not correctly express pass needs, as it requires the use of wl-clipboard if $WAYLAND_DISPLAY is set, and of xclip if $DISPLAY is set. We can probably add a `Requires: wl-clipboard` as its only wayland-specific dependency is libwayland-client which has no further deps. Not sure what to do about xclip though. Maybe just a weak dep? Hello, After a consultation with expert. I think the best solution could be something like: Requires: (wl-clipboard if libwayland-client else xclip) Requires: (xclip if xorg-x11-server-Xorg else wl-clipboard) Ah, I did not know this was possible, thanks a lot! Do you know why the `else xclip`/`else wl-clipboard` fallbacks are needed? It seems to me that ``` Requires: (wl-clipboard if libwayland-client) Requires: (xclip if xorg-x11-server-Xorg) ``` should work well enough, especially for headless setups? (though I'm not sure how well pass would work there) 'libx11' might be better than 'xorg-x11-server-Xorg', this is what xclip depends on, and similar to libwayland-client I believe? *** Bug 2002593 has been marked as a duplicate of this bug. *** FEDORA-2021-7822811209 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7822811209 FEDORA-2021-7822811209 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. I've only pushed the build to rawhide for now, this will need to be merged back to all the stable release once it's seen a bit of testing. I see that this has been fixed for F33, F35 and F36, but the F34 update is still pending in https://koji.fedoraproject.org/koji/buildinfo?buildID=1844157 Is there something blocking it? I also couldn't find 1.7.4-2 in Bodhi. > I also couldn't find 1.7.4-2 in Bodhi.
Sorry, I meant 1.7.4-2.fc34
FEDORA-2021-01fcc023c1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01fcc023c1 FEDORA-2021-4f95aded14 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4f95aded14 FEDORA-2021-126b5679df has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-126b5679df > Is there something blocking it?
Nothing special, just that I made the builds, switched to something different while they were being completed, and never filed the bodhi updates :)
FEDORA-2021-01fcc023c1 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-01fcc023c1` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01fcc023c1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-126b5679df has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-126b5679df` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-126b5679df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-4f95aded14 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-4f95aded14` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4f95aded14 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. (In reply to Jiri Konecny from comment #2) > Hello, > > After a consultation with expert. I think the best solution could be > something like: > > Requires: (wl-clipboard if libwayland-client else xclip) > Requires: (xclip if xorg-x11-server-Xorg else wl-clipboard) This is wrong. Having libwayland-client installed doesn't imply you're actually running a Wayland session. libwayland-client is pulled as dependency on many essential packages even in a Xorg-only desktops such as MATE. Please just add Recommends: on both xclip and wl-clipboard and be done with it. FEDORA-2021-126b5679df has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-01fcc023c1 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-4f95aded14 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |