Bug 1996798
| Summary: | Review Request: ghc-cached-json-file - Locally cache a json file obtained by http | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <spotrh> |
| Status: | MODIFIED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, spotrh |
| Target Milestone: | --- | Flags: | spotrh:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ghc-cached-json-file-0.1.1-14.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jens Petersen
2021-08-23 17:26:50 UTC
Spec URL: https://petersen.fedorapeople.org/reviews/ghc-cached-json-file/ghc-cached-json-file.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-cached-json-file/ghc-cached-json-file-0.1.0-2.fc35.src.rpm drop %autorelease for review Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=79079896 This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. Spec URL: https://petersen.fedorapeople.org/reviews/ghc-cached-json-file/ghc-cached-json-file.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-cached-json-file/ghc-cached-json-file-0.1.1-1.fc38.src.rpm https://hackage.haskell.org/package/cached-json-file-0.1.1/changelog Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=96986905 This library is used by fbrnch via ghc-fedora-dists Copr build: https://copr.fedorainfracloud.org/coprs/build/5399896 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1996798-ghc-cached-json-file/fedora-rawhide-x86_64/05399896-ghc-cached-json-file/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service APPROVED (generated packages are so simple) Good: - rpmlint checks return: ghc-cached-json-file-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.2.6/lib/cached-json-file-0.1.1/libHScached-json-file-0.1.1-9nkhzHX7d8f8HC0nyuYTuZ.a ghc-cached-json-file-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.2.6/lib/cached-json-file-0.1.1/libHScached-json-file-0.1.1-9nkhzHX7d8f8HC0nyuYTuZ_p.a ghc-cached-json-file.x86_64: W: no-documentation ghc-cached-json-file-prof.x86_64: W: no-documentation ghc-cached-json-file-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-9.2.6/lib/cached-json-file-0.1.1/libHScached-json-file-0.1.1-9nkhzHX7d8f8HC0nyuYTuZ_p.a All safe to ignore for Haskell packages. - package meets naming guidelines - package meets packaging guidelines - license (BSD-3-Clause) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - doc subpackage okay - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - devel requires base package n-v-r Thank you very much 🙏 The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-cached-json-file |