Bug 1997019

Created attachment 1831780 [details]
proposed fix

Tests in web ui:
1. 
* Create a colocation constraint with "together" placement. 
* The created constraint should be displayed with "together" placement.

2. 
* Start creation of an order constraint with resource sets. 
* Add resource in the first resource set.
* Add new resource set but don't select any resource.
* Click "next".
* You should stay on the same step with validation error.

3.
* Create a ticket constraint and select "no-limitation" for role.
* The created constraint should be displayed without role specification.

4.
* Create a ticket constraint and select e.g. "Started" for role.
* The constraint should be created successfully.

5.
* Delete a ticket constraint.
* The constraint should be deleted successfully.

DevTestResults:

[root@r90-node-01 ~]# rpm -q pcs
pcs-0.11.1-4.el9.x86_64


Issue 1) colocation constraint, together, score=20
Result:
Type Colocation
Resources d1 in role Started and d2 in role Started are together
Score 20

Issue 2) order set & colocation set with more resource sets
If you try to create order/colocation set constraint with empty resource sets then a red note will show up after clicking on the 'Next' button:
a) 1st resource set: Please provide at least 2 resources
b) 2nd and subsequent sets: Please provide at least 1 resource

Wizard will not continue to the next step.

Issue 3)
a) ticket constraint - Ticket: T1, loss policy: stop, Resource: d1, Role: no limitation
Result: Type Ticket     Resource d1 depends on ticket T1

b) ticket constraint set - Resource set 1: d2, d3,  Role: no limitation, Ticket: T2, Loss policy: stop
Result: Type Ticket (set)   Resources d2, d3 depends on ticket T2


Issue 4) ticket constraint with other role then 'no limitation' can be created:

Result: Type Ticket     Resource d1 in role Started depends on ticket T1

Issue 5) deleting of ticket constraints

Result: ticket constraints can be deleted

DevTestResults:

[root@r90-node-01 ~]# rpm -q pcs
pcs-0.11.1-6.el9.x86_64

1) Ticket constraint with other role than "no limitation" can be crated.

Ticket: T1, Loss policy: stop (default), Resource: d-01, Role: Started

Result:

Type Ticket
Resource d-01 in role Started depends on ticket T1
Loss policy stop

2) Ticket constraint shows loss policy

AFTER FIX:
==========

in cli:

[root@virt-508 ~]# rpm -q pcs
pcs-0.11.1-6.el9.x86_64

[root@virt-508 ~]# pcs resource
  * d1	(ocf:heartbeat:Dummy):	 Started virt-510
  * d2	(ocf:heartbeat:Dummy):	 Started virt-510


in web UI:

1. Open new web UI (https://nodename:2224/)
2. Log in
3. Click on 'Add existing cluster' button and proceed with the wizard
4. Click on the added cluster
5. Switch to 'Constraints' tab


## cases from comment 0.

# case 1: colocation constraint, together placement, score 20
'Type Colocation
Resources d1 in role Started and d2 in role Started are together
Score 20'

> OK: The constraint is no longer shown with 'apart' description


# case 2: order set constraint, 2 resource sets, the second set is empty

> OK: There is now a check for the subsequent sets with error message: "Please provide at least 1 resource"

# colocation set constraint, 2 resource sets, the second set is empty

> OK: Same as the order set constraint, this case is now covered with message: "Please provide at least 1 resource"


# case 3: ticket constraint, role no limitation 
'Type Ticket    
Resource d1 depends on ticket test 
Loss policy stop' 
 
> OK: The role is not "Started", when no limitation is specified

# ticket set constraint, role no limitation
'Type Ticket (set)

    Resources d1, d2 depends on ticket test

Loss policy stop'

> OK


# case 4: ticket constraint, role Started
'Type Ticket
Resource d1 in role Stopped depends on ticket test
Loss policy stop'

> OK: The role is correct and the loss policy is shown

# ticket constraint, loss policy fence, role Started
'Type Ticket
Resource d1 in role Started depends on ticket test
Loss policy fence'

> OK

# ticket constraint, loss policy demote, role Promoted
'Type Ticket
Resource d1 in role Promoted depends on ticket test
Loss policy demote'

> OK

# ticket constraint, loss policy freeze, role Unpromoted, custom_id
'Type Ticket
Resource d1 in role Unpromoted depends on ticket test
Loss policy freeze'

> OK

# ticket set constraint, role Started
'Type Ticket (set)

    Resources d1, d2 in role Started depends on ticket test

Loss policy stop'

> OK

# ticket set constraint, role Stopped, Loss policy freeze
'Type Ticket (set)

    Resources d1, d2 in role Stopped depends on ticket test

Loss policy freeze'

# ticket set constraint, first set Promoted, second set Unpromoted, Loss policy demote
'Type Ticket (set)

Resources d1 in role Promoted depends on ticket test

    Resources d2 in role Unpromoted depends on ticket test

Loss policy demote'

> OK


# case 5: ticket and ticket sets

> OK: ticket and ticket set constraints can be deleted


## case mentioned in comment 8

# colocation set constraint, role Promoted
'Type Colocation (set)

    Resources d1, d2 in role Started are together
    Score INFINITY
'

> OK: UI still communicates without a problem

# colocation set constraint, role Unpromoted
'Type Colocation (set)

Resources d1, d2 in role Unpromoted are together
'

> OK: UI still communicates


Marking as VERIFIED in pcs-0.11.1-6.el9

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: pcs), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2290