Bug 199747
| Summary: | Review Request: pingus - Guide the penguins safely home before they drop of the cliff | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
| Component: | Package Review | Assignee: | Paul F. Johnson <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-25 11:32:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 199630 | ||
| Bug Blocks: | 163779 | ||
|
Description
Hans de Goede
2006-07-21 18:22:10 UTC
Okay, from a very quick glance over... needs BR get-text I'll check it over more closely tonight Darn, I spend hours getting the gettext support to work and still forgot to add the BR. I will add that together with any other nescesarry changes once a full review is done, or if some other changes come up before that. Once I add the BR for get-text, everything is happy under mock and rpmlint comes up clean. The icon installs correctly under games. One concern is that the website only has version 0.6.0 as the stable release and not 0.7.0 as available here. I couldn't find it in the development area either. If you can make the BR and version number changes, this is good to go. If you look at the first screen when you start pingus it will welcome you to pingus 0.7.0 . As you can see in the spec this is a svn snapshot, which is also reflected in the release: 0.1.20060721 . The current svn trunk is destined to become 0.7.0 some day (hopefully soon), so calling it 0.6.x is wrong, since it is not 0.6.x. Not a problem, it's just the BR and out the door it can go! New spec with fixed BR here: Spec URL: http://people.atrpms.net/~hdegoede/pingus.spec Notice I didn't upload a new SRPM as its huge and my uplink is quite slow. I could get the original spec file version to compile happily under mock, but the current one gives me an error that clanlib-devel cannot be found. Is this an SELinux related problem? ?? Are you sure, ClanLib has recently been build and hasn't hit the repo yet (atleast not my mirror) also clanlib is only available in the development repo (waiting for CVS branching). So I don't find it strange it doesn't build in mock, I do find it strange it once did build :) I have a local repo for this sort of thing which is why it built originally. Is ClanLib still in this repo? From memory, yes. I'll need to check though (it was last time I looked) D'oh, the cache was chomped. I'm happy for this to be released now. APPROVED Thanks! Imported and Build, closing. p.s. For the next review, when you approve a package you should change the blocker bug from FE-REVIEW to FE-ACCEPT . I've done that for the 2 ClanLib's and I'll do it for this one. |