Bug 1998062

Summary: Rsync pod uses upstream image
Product: Migration Toolkit for Containers Reporter: Xin jiang <xjiang>
Component: ControllerAssignee: Pranav Gaikwad <pgaikwad>
Status: CLOSED ERRATA QA Contact: Xin jiang <xjiang>
Severity: urgent Docs Contact: Avital Pinnick <apinnick>
Priority: urgent    
Version: 1.6.0CC: ernelson, jmontleo, rjohnson, sregidor, ssingla, whu
Target Milestone: ---   
Target Release: 1.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-29 14:35:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Xin jiang 2021-08-26 11:28:54 UTC 
Description of problem:
While executing direct migration, we found the rsync pod is using image "quay.io/konveyor/rsync-transfer:latest" 


Version-Release number of selected component (if applicable):
MTC 1.6.0

image: registry.redhat.io/rhmtc/openshift-migration-controller-rhel8@sha256:41985177ac340e405d2ad94eb38f5bf61389ff13ad60b8f9031c916253b91b1f

How reproducible:
Always

Steps to Reproduce:
1. Prepare 2 OCP cluster 4.6 -> 4.9 and deploy MTC 1.6.0 on the both cluster
2. execute a direct migration
ansible-playbook  -i inventory.cam.yml -e @config/direct_copy_defaults.yml ocp-24769-cakephp.yml -e with_validate_target=false
3. check event in the application namespace on source or target cluster
oc -n ocp-24769-cakephp get event

Actual results:
you will see creating rsync pod is pulling image "quay.io/konveyor/rsync-transfer:latest"

105m        Normal    Pulling                       pod/rsync-server                                 Pulling image "quay.io/konveyor/rsync-transfer:latest"
105m        Normal    Pulled                        pod/rsync-server                                 Successfully pulled image "quay.io/konveyor/rsync-transfer:latest" in 852.905861ms
105m        Normal    Created                       pod/rsync-server                                 Created container rsync
105m        Normal    Started                       pod/rsync-server                                 Started container rsync
105m        Normal    Pulling                       pod/rsync-server                                 Pulling image "quay.io/konveyor/rsync-transfer:latest"
105m        Normal    Pulled                        pod/rsync-server                                 Successfully pulled image "quay.io/konveyor/rsync-transfer:latest" in 839.382409ms

Expected results:
It should pull image from downstream registry

Additional info:
Comment 1 Jason Montleon 2021-08-27 14:40:44 UTC 
The rsync and stunnel images are hard coded in the crane-lib state_transfer library. We need to implement a way to override these with an image we specify.
Comment 5 Xin jiang 2021-09-06 11:40:18 UTC 
verified with MTC 1.6.0

7m59s       Normal    Pulled                        pod/rsync-268pv                                  Container image "registry.redhat.io/rhmtc/openshift-migration-rsync-transfer-rhel8@sha256:d1204d61cf8d028800f6b1f962dd1bfaff13af08a512821a17526b443d3ad2e8" already present on machine
Comment 6 Xin jiang 2021-09-06 13:20:31 UTC 
it depends on 2 images, one of them is still upstream image.

  containerStatuses:
  - containerID: cri-o://c162fca9d196aa5cd740dd167281e0444d944233c2547906ac17f94de0580b5a
    image: registry.redhat.io/rhmtc/openshift-migration-rsync-transfer-rhel8@sha256:d1204d61cf8d028800f6b1f962dd1bfaff13af08a512821a17526b443d3ad2e8
    imageID: registry.redhat.io/rhmtc/openshift-migration-rsync-transfer-rhel8@sha256:cfc43cf80147bf16ff079d51b628461ee17dec328c8fe5ea30904c9b158c65b7
    lastState: {}
    name: rsync
    ready: true
    restartCount: 0
    started: true
    state:
      running:
        startedAt: "2021-09-06T13:17:29Z"
  - containerID: cri-o://8307cd621b0094b66d7b17295214fa48078c6a149d303d8adf6dea1de5e986b8
    image: quay.io/konveyor/rsync-transfer:latest
    imageID: quay.io/konveyor/rsync-transfer@sha256:00b23827332d40b4b931ee3e05538f9885c1fa7a00b52f507d135b8ce9308f76
Comment 8 Xin jiang 2021-09-10 04:33:00 UTC 
verified with MTC 1.6.0

14s         Normal   Pulling          pod/rsync-server   Pulling image "registry.redhat.io/rhmtc/openshift-migration-rsync-transfer-rhel8@sha256:d1204d61cf8d028800f6b1f962dd1bfaff13af08a512821a17526b443d3ad2e8"
7s          Normal   Pulled           pod/rsync-server   Successfully pulled image "registry.redhat.io/rhmtc/openshift-migration-rsync-transfer-rhel8@sha256:d1204d61cf8d028800f6b1f962dd1bfaff13af08a512821a17526b443d3ad2e8" in 7.203261429s
7s          Normal   Created          pod/rsync-server   Created container rsync
7s          Normal   Started          pod/rsync-server   Started container rsync
7s          Normal   Pulled           pod/rsync-server   Container image "registry.redhat.io/rhmtc/openshift-migration-rsync-transfer-rhel8@sha256:d1204d61cf8d028800f6b1f962dd1bfaff13af08a512821a17526b443d3ad2e8" already present on machine
7s          Normal   Created          pod/rsync-server   Created container stunnel
7s          Normal   Started          pod/rsync-server   Started container stunnel
Comment 10 errata-xmlrpc 2021-09-29 14:35:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Migration Toolkit for Containers (MTC) 1.6.0 security & bugfix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3694