Bug 1998192

Summary: sqlite_idxdbByKey(): NULL-pointer dereference
Product: Red Hat Enterprise Linux 8 Reporter: Michal Domonkos <mdomonko>
Component: rpmAssignee: Packaging Maintenance Team <packaging-team-maint>
Status: CLOSED NOTABUG QA Contact: swm-qe
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.4CC: pmatilai
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-01 08:25:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michal Domonkos 2021-08-26 14:48:55 UTC
Error: CLANG_WARNING:
rpm-4.14.3/lib/backend/sqlite.c:555:10: warning[core.NullDereference]: Dereference of null pointer (loaded from variable 'set')
#  553|   	    unsigned int tnum = sqlite3_column_int(dbc->stmt, 1);
#  554|   
#  555|-> 	    if (*set == NULL)
#  556|   		*set = dbiIndexSetNew(5);
#  557|   	    dbiIndexSetAppendOne(*set, hnum, tnum, 0);

Error: CLANG_WARNING:
rpm-4.14.3/lib/backend/sqlite.c:562:7: warning[core.NullDereference]: Dereference of null pointer (loaded from variable 'set')
#  560|   
#  561|       if (rc == SQLITE_DONE) {
#  562|-> 	rc = (*set) ? RPMRC_OK : RPMRC_NOTFOUND;
#  563|       } else {
#  564|   	rc = dbiCursorResult(dbc);

Comment 1 Panu Matilainen 2021-08-27 08:09:16 UTC
This is a false positive, `set` is always non-NULL in the application logic (otherwise nothing at all would work)