Bug 1998339

Summary: Review Request: python-google-cloud-asset - Python Client for Google Cloud App Engine Admin
Product: [Fedora] Fedora Reporter: Major Hayden 🤠 <mhayden>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-10-05 16:48:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1998334    
Bug Blocks:    

Description Major Hayden 🤠 2021-08-26 20:40:19 UTC 
Spec URL: https://mhayden.fedorapeople.org/python-google-cloud-asset.spec
SRPM URL: https://mhayden.fedorapeople.org/python-google-cloud-asset-3.4.0-1.fc34.src.rpm

Description:
App Engine Admin allows you to manage your App Engine applications.

Fedora Account System Username: mhayden
Comment 1 Major Hayden 🤠 2021-08-26 20:42:18 UTC 
COPR fedora-review: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02673258-python-google-cloud-asset/fedora-review/review.txt
Comment 2 Major Hayden 🤠 2021-10-04 12:21:53 UTC 
This one is stuck waiting on a dependency bump for access-context-manager in BZ 1998334.
Comment 3 Neal Gompa 2021-10-05 12:58:23 UTC 
Taking this review.
Comment 4 Neal Gompa 2021-10-05 12:58:50 UTC 
This one needs to be uploaded again, as all the links 404.
Comment 5 Major Hayden 🤠 2021-10-05 13:47:47 UTC 
Updated:

Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02875038-python-google-cloud-asset/python-google-cloud-asset.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02875038-python-google-cloud-asset/python-google-cloud-asset-3.6.1-1.fc36.src.rpm
Comment 6 Neal Gompa 2021-10-05 13:49:14 UTC 
Review notes:

* Package is named correctly
* Package follows proper conventions for new-style Python packages
* Package builds and installs (once dependencies are installed)
* No serious issues from rpmlint

PACKAGE APPROVED.
Comment 7 Gwyn Ciesla 2021-10-05 16:08:15 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-google-cloud-asset