Bug 2000349

This will collide on import level with https://src.fedoraproject.org/rpms/python-ghp-import2 and should at least explicitly conflict with it (if not replace it). Note that ghp-import2 was a fork of ghp-import when ghp-import was dead upstream, but since then, the roles reversed and ghp-import supersedes ghp-import2

Spec URL: https://smani.fedorapeople.org/review/python-ghp-import.spec
SRPM URL: https://smani.fedorapeople.org/review/python-ghp-import-2.0.1-2.fc36.src.rpm

%changelog
* Thu Sep 02 2021 Sandro Mani <manisandro> - 2.0.1-2
- Port to new Python guidelines
- Obsolete/provide python3-ghp-import2

CC @jamatos

> Obsolete/provide python3-ghp-import2

python-nikola needs to be adapted to use python3-ghp-import.

There is no %check section. I don't think upstream has tests, so at least very the module can be imorted:


%check
%py3_check_import ghp_import

Spec URL: https://smani.fedorapeople.org/review/python-ghp-import.spec
SRPM URL: https://smani.fedorapeople.org/review/python-ghp-import-2.0.1-3.fc36.src.rpm

%changelog
* Fri Sep 03 2021 Sandro Mani <manisandro> - 2.0.1-3
- Run %%py3_check_import ghp_import in %%check

Here [1] is a PR for adapting python-nikola to ghp-import as soon as this review is done.


[1] https://src.fedoraproject.org/rpms/python-nikola/pull-request/1

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


MUST FIX:

   invalid-license ASL2.0, it should be ASL 2.0

SHOULD fix:

   non-executable-script /usr/lib/python3.10/site-packages/ghp_import.py 644 /usr/bin/env python
   (drop the shebang, ideally in upstream)


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Apache License 2.0", "Unknown or generated",
     "*No copyright* Apache License". 10 files have unknown license.
     Detailed output of licensecheck in
     /home/churchyard/rpmbuild/FedoraReview/2000349-python-ghp-
     import/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[-]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-ghp-import-2.0.1-3.fc36.noarch.rpm
          python-ghp-import-2.0.1-3.fc36.src.rpm
python3-ghp-import.noarch: W: invalid-license ASL2.0
python3-ghp-import.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/ghp_import.py 644 /usr/bin/env python
python3-ghp-import.noarch: W: no-manual-page-for-binary ghp-import
python-ghp-import.src: W: invalid-license ASL2.0
2 packages and 0 specfiles checked; 1 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/ghp-import/ghp-import-2.0.1.tar.gz :
  CHECKSUM(SHA256) this package     : 753de2eace6e0f7d4edfb3cce5e3c3b98cd52aadb80163303d1d036bda7b4483
  CHECKSUM(SHA256) upstream package : 753de2eace6e0f7d4edfb3cce5e3c3b98cd52aadb80163303d1d036bda7b4483


Requires
--------
python3-ghp-import (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.10dist(python-dateutil)



Provides
--------
python3-ghp-import:
    python-ghp-import
    python3-ghp-import
    python3-ghp-import2
    python3.10-ghp-import
    python3.10dist(ghp-import)
    python3dist(ghp-import)

(In reply to Sandro Mani from comment #6)
> Here [1] is a PR for adapting python-nikola to ghp-import as soon as this
> review is done.
> 
> 
> [1] https://src.fedoraproject.org/rpms/python-nikola/pull-request/1

Hi Sandro, that is OK. I let a note saying precisely that on the pull-request.

Thanks for taking care of this.

Thanks for the comments, I've implemented these in -4:

Spec URL: https://smani.fedorapeople.org/review/python-ghp-import.spec
SRPM URL: https://smani.fedorapeople.org/review/python-ghp-import-2.0.1-4.fc36.src.rpm

%changelog
* Mon Sep 27 2021 Sandro Mani <manisandro> - 2.0.1-4
- Fix ASL2.0 -> ASL 2.0
- Strip shebang on non-executable script

Suggestion: Use this single sed instead of your if-then-sed:

    sed -i '1{/^#!/d}'


Package APPROVED.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ghp-import

FEDORA-2021-b64381b8fa has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

https://src.fedoraproject.org/rpms/python-ghp-import2/c/4cdce0e7814b9f17804247f8c1bd6142b00a64e0?branch=rawhide