Bug 2000763
| Summary: | Review Request: wike - Wikipedia Reader for the GNOME Desktop | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gustavo Costa <xfgusta> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | code, jamatos, package-review |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-10-21 19:50:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Gustavo Costa
2021-09-02 20:34:52 UTC
I will take the review and sponsor you. The review will come soon. Thank you, José, for sponsoring me. Hi Gustavo, the spec file is quite simple but I have some doubts about it. BuildRequires: libhandy1-devel Why is this required at build time? About installation time I suspect that these requirements are dealt by python3-gobject, right? Requires: gtk3 Requires: libhandy1 Requires: webkit2gtk3 (In reply to José Matos from comment #3) > Hi Gustavo, > the spec file is quite simple but I have some doubts about it. Hi José. I hope I can clarify your doubts. > BuildRequires: libhandy1-devel > Why is this required at build time? Actually, libhandy1-devel is not required to build Wike. I found out that only glib2-devel, which is a libhandy's dependency [1], is used. The glib2-devel is used because of the glib-compile-resources utility [2]. I've already updated the spec file changing libhandy1-devel to glib2-devel. > About installation time I suspect that these requirements are dealt by > python3-gobject, right? > Requires: gtk3 > Requires: libhandy1 > Requires: webkit2gtk3 gtk3, libhandy1, and webkit2gtk3 are used with python3-gobject [3][4], but python3-gobject doesn't provide them. 1. dnf repoquery --depends libhandy-devel 2. https://github.com/hugolabe/Wike/blob/aad1b4c96313b160b68e708a183948b04b1ff15b/data/meson.build#L1 3. https://github.com/hugolabe/Wike/blob/master/src/header.py#L23 4. https://github.com/hugolabe/Wike/blob/master/src/view.py#L25 Spec URL: https://xfgusta.fedorapeople.org/packages/wike/wike.spec SRPM URL: https://xfgusta.fedorapeople.org/packages/wike/wike-1.5.6-1.fc34.src.rpm - Update to 1.5.6 - Remove BR libhandy1-devel - Add BR glib2-devel Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=75437262 Spec URL: https://xfgusta.fedorapeople.org/packages/wike/wike.spec SRPM URL: https://xfgusta.fedorapeople.org/packages/wike/wike-1.5.7-1.fc34.src.rpm - Update to 1.5.7 I have sponsored into the packagers group. I will finish soon the review and then you can import the package. The license is correct and acceptable for Fedora. fedora-review does have a minor complaint regarding the ownership of /usr/share/gnome-shell/search-providers and /usr/share/gnome-shell/ Here on F35 I have: # rpm -qf /usr/share/gnome-shell/search-providers gnome-terminal-3.40.3-1.fc35.x86_64 gnome-photos-40.0-3.fc35.x86_64 gnome-clocks-40.0-2.fc35.x86_64 gnome-contacts-41~beta-1.fc35.x86_64 gnome-shell-41.0-1.fc35.x86_64 gnome-boxes-41.1-1.fc35.x86_64 nautilus-41.0-1.fc35.x86_64 gnome-calendar-41.0-1.fc35.x86_64 gnome-calculator-41.0-1.fc35.x86_64 gnome-weather-41.0-1.fc35.noarch Since wike can be used without gnome-shell this is a minor issue that can be solved later. The spec file is simple, well written and correct so the package is approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wike |