Bug 2001063

Summary:	backport build fix to add symbol versions
Product:	Red Hat Enterprise Linux 8	Reporter:	Eric Garver <egarver>
Component:	json-c	Assignee:	Tomas Korbar <tkorbar>
Status:	CLOSED ERRATA	QA Contact:	František Hrdina <fhrdina>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.5	CC:	fhrdina, jorton, pemensik, psklenar
Target Milestone:	rc	Keywords:	AutoVerified, TestCaseProvided, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	json-c-0.13.1-3.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2001067 2219521 (view as bug list)		Environment:
Last Closed:	2022-05-10 15:21:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2001067, 2021812, 2021813, 2021814, 2021815, 2021816, 2021817, 2021818, 2021819, 2021823, 2021824, 2021825, 2021826, 2021827, 2021828, 2021829, 2021832, 2021833, 2021834, 2219521

Description Eric Garver 2021-09-03 17:02:40 UTC

This bug was initially created as a copy of Bug #2001062

I am copying this bug because: same thing applies to json-c



Multiple JSON libraries have the same API functions. This can cause the wrong function to be used if there are multiple JSON libraries in the dynamic library list. This may manifest as a segfault or very odd behavior. Fixing these libraries will of course require recursive version bumps and rebuilds of packages that use them so they utilize the versioned symbol.

The "very odd behavior" case is very interesting. See this firewalld bug report:

  https://github.com/firewalld/firewalld/issues/819

In the firewalld case, python GI module pulls in libmount which pulls in libcryptsetup which pulls in json-c.

Example conflict: libnftables uses libjansson. libcryptsetup uses json-c. It's not clear which json_object_get() function will be used.

Note: JSON-GLib is also likely affected. But I did not track down any fixes on their end. If 2/3 of the libraries are versioned then I _think_ it should be okay.

--

firewalld bug report: https://github.com/firewalld/firewalld/issues/819
guestfs bug report: bug 1923971
jansson bug report: https://github.com/akheron/jansson/issues/460
json-c bug report: https://github.com/json-c/json-c/issues/621

Upstream fixes:

  jansson: https://github.com/akheron/jansson/pull/540
  json-c: https://github.com/json-c/json-c/pull/639

Comment 10 Petr Menšík 2021-11-15 18:18:05 UTC

When checked result on rawhide, exported symbols seem to be different in json-c-0.15-2.fc35.x86_64.

# nm -D /usr/lib64/libjson-c.so.* | grep json_ | tail -3
00000000000066d0 T json_tokener_set_flags@@JSONC_0.14
0000000000006c60 T json_type_to_name@@JSONC_0.14
0000000000006710 T json_util_get_last_err@@JSONC_0.14

But on RHEL8 no versions are present.
# nm -D /usr/lib64/libjson-c.so.* | grep @ | wc -l
0

Is it correct? It seems to me unversioned symbols have to be kept for backward compatibility, but versioned symbols should be provided in addition. New version has still only unversioned symbols. Would it be enough to avoid conflict in single binary?

Comment 11 Petr Menšík 2021-11-15 20:51:44 UTC

objdump -T /lib64/libjson-c.so.* prints JSONC_0.14 namespace in both. Maybe just nm tool abilities have changed in Rawhide.

Comment 18 errata-xmlrpc 2022-05-10 15:21:02 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (json-c bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2027