Bug 2001791

Summary:	remove unused `sbus_timeout` option
Product:	Red Hat Enterprise Linux 8	Reporter:	ttuffin
Component:	sssd	Assignee:	Alexey Tikhonov <atikhono>
Status:	CLOSED UPSTREAM	QA Contact:	sssd-qe <sssd-qe>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	8.4	CC:	atikhono, grajaiya, jhrozek, lslebodn, mzidek, pbrezina, tscherf
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	sync-to-jira review
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-06 09:00:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description ttuffin 2021-09-07 08:05:14 UTC

Description of problem:
The parameter 'sbus_timeout' is not defined in the sssd.conf manpages, but checking upstream it seems to still be a valid parameter [1].

[1] https://github.com/SSSD/sssd/blob/master/src/config/etc/sssd.api.conf

Version-Release number of selected component (if applicable):
sssd-2.4.0-9.el8_4.2.x86_64

How reproducible:
Always

Steps to Reproduce:
1. # man sssd.conf
2. **search for sbus_timeout**

Actual results:
sbus_timeout missing from SSSD.CONF(5).

Expected results:
sbus_timeout is defined in SSSD.CONF(5).

Additional info:

Comment 1 Alexey Tikhonov 2021-09-07 08:50:06 UTC

This option is only read by "monitor" (main sssd process) in `get_monitor_config()` from [sssd] section, assigned to `mt_ctx::service_id_timeout` and, it seems , never actually used.
Probably a leftover to be removed.

Comment 2 ttuffin 2021-09-07 11:43:26 UTC

@atikhono makes sense. The last time it was mentioned in the RHEL docs was RHEL6. Do you know which version of sssd this parameter was first made obsolete? Every now and then I come across this parameter still being used in a current sssd.conf.

Comment 3 Alexey Tikhonov 2021-09-07 11:49:10 UTC

(In reply to ttuffin from comment #2)
> Do you know which version of sssd this parameter was first made obsolete?

I guess since 2.0 upstream, i.e. RHEL8.0

This option is still used by 'monitor' in 1-16 branch, i.e. in RHEL7.

Comment 4 Alexey Tikhonov 2021-10-01 16:17:00 UTC

Upstream PR: https://github.com/SSSD/sssd/pull/5803