Bug 2001986

Summary:	[nm-next] rework NMDhcpClient API for next
Product:	Red Hat Enterprise Linux 8	Reporter:	Thomas Haller <thaller>
Component:	NetworkManager	Assignee:	Beniamino Galvani <bgalvani>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.5	CC:	atragler, bgalvani, ferferna, fge, lrintel, rkhan, sukulkar, till, vbenes
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Feature: rework NMDhcpClient API for next Reason: bug 1868254 is about reworking the core of NetworkManager that does IP configuration. That is a huge task, and currently in progress on upstream "next" branch. This is a individual, separate part of this effort. NMDhcpClient's API needs to be reworked, to simplify its user (NMDevice). Result:	Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-12-20 13:34:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1868254

Description Thomas Haller 2021-09-07 15:34:53 UTC

bug 1868254 is about reworking the core of NetworkManager that does IP configuration. That is a huge task, and currently in progress on upstream "next" branch.

This is a individual, separate part of this effort.

NMDhcpClient's API needs to be reworked, to simplify its user (NMDevice).


The details are described in https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/next/src/core/dhcp/README.next.md

The API already changed and the current WIP work ("next" branch) is about to use it. What needs to be done, is to implement it properly.

Comment 2 Beniamino Galvani 2021-12-20 13:34:36 UTC

next branch was merged, see bug 1868254.

Comment 3 Thomas Haller 2022-01-21 19:30:29 UTC

but this was not completed. At least not, what was described in https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/26c43e4bccfeedc0028606794139c1749fdaf49f/src/core/dhcp/README.next.md

Or is it?

Comment 4 Beniamino Galvani 2022-12-12 08:41:09 UTC

It seems to me most of the change in that document are implemented now, perhaps except the start() and stop() changes.