Bug 2002058
| Summary: | Review Request: cockpit-navigator - A File System Browser for Cockpit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stephen Gallagher <sgallagh> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | cockpit-navigator-0.5.4-1.fc36 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-09-08 15:06:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Stephen Gallagher
2021-09-07 19:49:59 UTC
Taking this review. Spec review notes: > %global debug_package %{nil} Since this is noarch, we don't need this... > /usr/share/cockpit/navigator/* This should be "%{_datadir}/cockpit/navigator/" (no asterisk) so that the navigator directory is correctly owned too. (In reply to Neal Gompa from comment #2) > Spec review notes: > > > %global debug_package %{nil} > > Since this is noarch, we don't need this... > That's left over from upstream's spec file. I'll drop it before I import. > > /usr/share/cockpit/navigator/* > > This should be "%{_datadir}/cockpit/navigator/" (no asterisk) so that the > navigator directory is correctly owned too. Same here; I can submit an updated spec for the review if you prefer or (if there are no further issues with it) you can approve it and I'll make sure it's fixed when I import. Review notes:
[x] Packaging follows general guidelines
[!] Package licensing is indicated correctly
* Add "%license LICENSE" to the file list
[x] Packaging builds and installs
[x] No serious issues from rpmlint
* Existing issues known and will be fixed on import
PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cockpit-navigator FEDORA-2021-46b1e53a03 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-46b1e53a03 FEDORA-2021-f8830972de has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f8830972de FEDORA-2021-46b1e53a03 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-04f68184b9 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-04f68184b9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-04f68184b9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-f8830972de has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-f8830972de \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f8830972de See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-04f68184b9 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-f8830972de has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |