Bug 20024
| Summary: | Initial NAK flush on XMODEM | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Need Real Name <jco> |
| Component: | lrzsz | Assignee: | Than Ngo <than> |
| Status: | CLOSED CANTFIX | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 6.2 | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | i386 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-10-18 14:47:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Could you please do diff -Nur instead diff again to make a patch file. Please send me the new patch file again. Thanks. Red Hat Linux is no longer supported by Red Hat, Inc. If you are still running Red Hat Linux, you are strongly advised to upgrade to a current Fedora Core release or Red Hat Enterprise Linux or comparable. Some information on which option may be right for you is available at http://www.redhat.com/rhel/migrate/redhatlinux/. Red Hat apologizes that these issues have not been resolved yet. We do want to make sure that no important bugs slip through the cracks. Please check if this issue is still present in a current Fedora Core release. If so, please change the product and version to match, and check the box indicating that the requested information has been provided. Note that any bug still open against Red Hat Linux on will be closed as 'CANTFIX' on September 30, 2006. Thanks again for your help. Red Hat Linux is no longer supported by Red Hat, Inc. If you are still running Red Hat Linux, you are strongly advised to upgrade to a current Fedora Core release or Red Hat Enterprise Linux or comparable. Some information on which option may be right for you is available at http://www.redhat.com/rhel/migrate/redhatlinux/. Closing as CANTFIX. |
Hello, If you remember, the Xmodem sender waits for the receiver to send a NAK character, then transmission begins. If the transmitter is started enough time later than the receiver does, more than one NAK char may be waiting in the transmitter's input buffer. The transmitter checks the initial NAK, sends the first packet and, as a response, he gets a NAK which is one of the extra NAKs sent by the receiver to signal Xmodem reception, not a real packet reject. In my opinion, the transmitter must consume all chars waiting in the buffer before operation starts. This is specially annoying when using "sx" from "minicom". If the user is not extremely fast typing the file name to be uploaded (very difficult), then all packes are "rejected" by this reason, and the upload becomes unsuccessful. I have patched "lsz.c" and now it works. Here is the patch, if you are interested : 1329d1328 < 1341,1346d1339 < < /* if the receiver has sent more than one NAK, they must be consumed, */ < /* otherwise they will be interpreted as packet rejects later (JCO) */ < while (firstch == NAK) < firstch=READLINE_PF(1); < 1409d1401 < { 1411,1412c1403 < } < --- > Over version 0.12.20-4. It can be extended for the CRC mode, however. Thank you.