Bug 2002814

Summary:	Please consider dropping the dependency on util-linux
Product:	[Fedora] Fedora	Reporter:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Component:	xfsprogs	Assignee:	Eric Sandeen <esandeen>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	esandeen
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-09-09 20:55:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zbigniew Jędrzejewski-Szmek 2021-09-09 19:10:42 UTC

Description of problem:
I'm building some minimal images with file system checkers, and xfsprogs is one of the few packages that pulls in util-linux. util-linux in F35+ is split into util-linux (11 MB) and util-linux-core (1 MB). It would be great if you could  drop the dependency altogether or downgrade it to Recommends or only depend on util-linux-core.

I'm not familiar with xfsprogs, so I couldn't figure out why exactly it's pulling in the dependency. fstrim is in util-linux, but I don't see it called anywhere in xfsprogs sources. Looking at the history, this dep was for fstrim, but now it's just calling the ioctl directly?

Version-Release number of selected component (if applicable):
xfsprogs-5.12.0-2.fc35.x86_64

Comment 1 Eric Sandeen 2021-09-09 19:27:10 UTC

It looks like we include it because we have one service script that invokes lsblk. However, that's for xfs_scrub, which later became its own subpackage.

I could easily move that into the xfs_scrub subpackage, for starters.  Which of the new util-linux subpackages contains lsblk?

Thanks,
-Eric

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-09-09 19:31:52 UTC

> I could easily move that into the xfs_scrub subpackage, for starters.

That'd be great.

> Which of the new util-linux subpackages contains lsblk?

util-linux unfortunately.

BTW, it's entirely OK to have Requires:/usr/bin/lsblk. It is against the guidelines
to have deps on paths outside a limited set, but anything in /usr/bin and /usr/sbin
is fine. Then the intent of the dependency is clearer, and also you don't care when the
file moves between subpackages.

Comment 3 Eric Sandeen 2021-09-09 20:55:42 UTC

Ok, the dependency is moved to the scrub subpackage in Rawhide now. Thanks for the heads up! thats' The proper place in any case.