Bug 2002993

Summary: [RHEL 9 Beta] Reenable SGA device
Product: Red Hat Enterprise Linux 9 Reporter: Richard W.M. Jones <rjones>
Component: qemu-kvmAssignee: Gerd Hoffmann <kraxel>
qemu-kvm sub component: Graphics QA Contact: Xueqiang Wei <xuwei>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: urgent    
Priority: urgent CC: coli, jinzhao, juzhang, kraxel, pvlasin, virt-maint
Version: 9.0Keywords: Regression, Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-kvm-6.0.0-13.el9_b.4 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2007521 (view as bug list) Environment:
Last Closed: 2021-12-07 21:20:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1995807, 2007521    

Description Richard W.M. Jones 2021-09-10 09:40:40 UTC
Description of problem:

A last minute change to the qemu-kvm package in RHEL 9 beta
breaks libguestfs (when used in verbose mode or with the
libvirt backend which is the default in RHEL).

See:
https://bugzilla.redhat.com/show_bug.cgi?id=1995807

Please reenable the SGA device.

Note this is for RHEL 9 Beta *only*, not RHEL 9 GA.

Version-Release number of selected component (if applicable):

qemu-kvm-6.0.0-13.el9_b.1

How reproducible:

100%

Steps to Reproduce:

Run:

$ libguestfs-test-tool
...
Original error from libvirt: internal error: qemu does not support SGA [code=1 int1=-1]

Comment 3 Richard W.M. Jones 2021-09-10 09:48:06 UTC
(In reply to RHEL Program Management from comment #2)
> A request has been made to complete this BZ as an exception (that is, after
> the deadline).  To facilitate review, the Product Owner (or a delegate) must
> provide an impact statement.  This is done by clicking the [reply] link on
> this comment, and then replying in-line to this message. 
>  This must be done to facilitate review, even if the case appears to be
> obvious, or is already covered elsewhere in the BZ. The exception will not
> be reviewed until this is done.
> 
> ======= Impact Statement ======= 
> 
> What is the benefit of making this change after the deadline? What is the
> impact on customer satisfaction, and on the business?
> 
> a. For bugfixes, there must be support from someone in Customer Support, a
> Partner Manager, Product Manager, and/or a Business Unit rep. (e.g.,
> potentially from a layered product BU). 
> b. It is unusual for new features to be allowed in the release after the
> deadline. For this reason, additional justification must be obtained from a
> stakeholder outside of the SST, to ensure an objective review of the benefit
> to the product. 
> 
> What is the risk to the release schedule, quality, and the impact of
> diverting resources from other efforts? Will there be enough time to do the
> necessary large-scale, cross-function, regression, stress, or
> fault-insertion testing that may be required to verify this change? 

The qemu change completely breaks libguestfs, guestfs-tools, virt-v2v etc.
It should be reverted to stop this breakage.

> ============================= 
> 
> In addition to the impact statement above, check the BZ to confirm the
> following: 
> 
> 1. The Internal Target Release (ITR) field reflects the correct release.
> 2. Set the Internal Target Milestone (ITM) field to indicate by when the
> work will be done. The approval for this exception will expire on that
> milestone. 
> 3. Ensure qa_ack+ and devel_ack+ are set, and that those acks are not
> leftover from before the exception request.
> 4. Prepare a RHEL rpm scratch build and have this change validated on the
> latest RHEL milestone compose by someone other than the developer. A comment
> must be added to the Bugzilla indicating the validation is successful and
> there were no observed regressions.
> 
> All of these steps must be complete before this change is reviewed as an
> exception.

Comment 7 Xueqiang Wei 2021-09-13 01:37:18 UTC
Need more time to verify it, so set ITM to 29

Comment 12 Xueqiang Wei 2021-09-18 08:55:15 UTC
Hi Gerd,

I tested with the latest qemu of rhel-9.0.0-beta, sga device is not reenabled. 

Since it will be ITM 30 soon, could you please help check the build status. Many thanks.


Versions:
qemu-kvm-6.0.0-13.el9_b.3 (https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1732965)

# /usr/libexec/qemu-kvm -device ?
Display devices:
name "bochs-display", bus PCI
name "cirrus-vga", bus PCI, desc "Cirrus CLGD 54xx VGA"
name "ramfb", bus System, desc "ram framebuffer standalone device"
name "secondary-vga", bus PCI
name "VGA", bus PCI
name "virtio-gpu-device", bus virtio-bus
name "virtio-gpu-pci", bus PCI, alias "virtio-gpu"
name "virtio-vga", bus PCI

# /usr/libexec/qemu-kvm -device sga
qemu-kvm: -device sga: 'sga' is not a valid device model name

Comment 17 Richard W.M. Jones 2021-09-24 10:49:42 UTC
I have verified this by downloading the -13.el9_b.3
and -13.el9_b.4 packages, downgrading first to .3,
reproducing the bug (libguestfs-test-tool fails with
error "qemu does not support SGA"), upgrading to .4,
and the error went away.

Comment 18 Xueqiang Wei 2021-09-24 17:43:12 UTC
Tested with qemu-kvm-6.0.0-13.el9_b.4, sga device has been re-enabled.

Versions:
kernel-5.14.0-3.el9.x86_64
qemu-kvm-6.0.0-13.el9_b.4



# /usr/libexec/qemu-kvm -device ?
Display devices:
name "bochs-display", bus PCI
name "cirrus-vga", bus PCI, desc "Cirrus CLGD 54xx VGA"
name "ramfb", bus System, desc "ram framebuffer standalone device"
name "secondary-vga", bus PCI
name "sga", bus ISA, desc "Serial Graphics Adapter"
name "VGA", bus PCI
name "virtio-gpu-device", bus virtio-bus
name "virtio-gpu-pci", bus PCI, alias "virtio-gpu"
name "virtio-vga", bus PCI


# /usr/libexec/qemu-kvm -device sga
VNC server running on ::1:5900

Comment 19 Xueqiang Wei 2021-09-24 17:48:24 UTC
Also tested libguestfs-test-tool with qemu-kvm-6.0.0-13.el9_b.4, it works well.

Tested seabios test loop with qemu-kvm-6.0.0-13.el9_b.4, no new bug found.

Comment 20 Yanan Fu 2021-09-26 02:08:57 UTC
QE bot(pre verify): Set 'Verified:Tested,SanityOnly' as gating/tier1 test pass.

Comment 21 Xueqiang Wei 2021-09-26 02:20:53 UTC
According to Comment 17, Comment 18 and Comment 19,  set status to VERIFIED. Thanks.