Bug 200395
| Summary: | broken initscript | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | ValueCommerce Infrastructure Team <infrastructure> | ||||
| Component: | ucarp | Assignee: | Matthias Saou <matthias> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5 | CC: | extras-qa | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 1.2-7 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-02-05 13:10:20 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 213321 | ||||||
| Attachments: |
|
||||||
This is the patch to /etc/init.d/carp:
--- carp.orig 2006-07-27 17:38:32.000000000 +0400
+++ carp 2006-07-27 17:41:04.000000000 +0400
@@ -15,7 +15,7 @@
[ ${NETWORKING} = "no" ] && exit 0
get_files() {
- FILES=`find /etc/sysconfig/carp -type f -name 'vip-*.conf' -maxdepth 1 \
+ FILES=`find /etc/sysconfig/carp -maxdepth 1 -type f -name 'vip-*.conf' \
-printf "%f\n" | LC_COLLATE="C" sort`
}
Thanks a lot for spotting this problem. The fix will be pushed once bug #200400 is also taken care of. Fixed packages of 1.2, which include a patch to bring the code up to the 1.3 snapshot, have just been rebuilt for FC-4, FC-5 and devel. They should be pushed shortly. Thank you. I continued to enhance the scripts until I got something that to my point of view could be useful to other UCARP users. With the changes offered one gets two benefits: 1. There is no dependency on initscripts files. 2. It is now possible to bind as many as needed IP addresses to a virtual router. There is a small drawback also: VIP_INTERFACE must be replaced with appropriate VIP_ADDRESS. You can find the src.rpm attached, it is built against the latest ucarp-1.2-3.fc5.src.rpm found in Fedora Extras 5. Created attachment 136730 [details]
the src.rpm
This has all been merged in the Fedora 7 package. Please have a look at it and let me know if anything else needs to be changed. Note that I've moved all files from /etc/sysconfig/carp/ to /etc/ucarp/ and renamed the service to "ucarp" (changed from carp to ucarp in many places to keep more consistent). The only minor enhancement I'd like to see is the ability to add an optional "label" to the VIP interfaces in order to have them show up in "ifconfig"'s output. Thank you, I will try to review on this weekend. |
Description of problem: The initscript uses invalid find call and thus doesn't work: # service carp restart find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it). Please specify options before other arguments. WARNING: initlog is deprecated and will be removed in a future release Starting common address redundancy protocol daemon: find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it). Please specify options before other arguments. [ OK ] Version-Release number of selected component (if applicable): ucarp-1.1-5.fc5